Simplify is_torchdynamo_compiling to direct import from torch.compiler#5618
Closed
cyyever wants to merge 1 commit intopytorch:mainfrom
Closed
Simplify is_torchdynamo_compiling to direct import from torch.compiler#5618cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever wants to merge 1 commit intopytorch:mainfrom
Conversation
Contributor
|
I think we might want to keep the existing code for backward compatibility reasons; there's a good chance it might break internal published models. |
Contributor
Author
|
@q10 it should work if the internal modules all use PyTorch 2. |
Contributor
|
@q10 has imported this pull request. If you are a Meta employee, you can view this in D100559702. |
cyyever
force-pushed
the
remove-is-torchdynamo-compiling
branch
from
32a96ca to
1e3edb0
Compare
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 14, 2026
pytorch#5618) Summary: X-link: facebookresearch/FBGEMM#2575 Reviewed By: henrylhtsang Differential Revision: D100559702 Pulled By: q10
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.