[mypyc] Fix range loop variable off-by-one after loop exit#21098
Merged
hauntsaninja merged 1 commit intopython:masterfrom Mar 26, 2026
Merged
[mypyc] Fix range loop variable off-by-one after loop exit#21098hauntsaninja merged 1 commit intopython:masterfrom
hauntsaninja merged 1 commit intopython:masterfrom
Conversation
04456ad to
a123591
Compare
Previously, ForRange.gen_step() updated both the internal index register and the user-visible loop variable after incrementing. This meant the loop variable was set to the incremented value before the condition check could reject it, causing an off-by-one overshoot on loop exit. Move the user-visible variable assignment to begin_body(), which runs after the condition check passes. The internal index register is still incremented in gen_step() but no longer propagated to the user variable until the next iteration's condition succeeds. Fixes mypyc/mypyc#1191
a123591 to
0cadfe6
Compare
hauntsaninja
approved these changes
Mar 26, 2026
Collaborator
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mypyc/mypyc#1191
Previously, ForRange.gen_step() updated both the internal index register and the user-visible loop variable after incrementing. This meant the loop variable was set to the incremented value before the condition check could reject it, causing an off-by-one overshoot on loop exit.