Add basic Goto Implementation Request support#644
Draft
smheidrich wants to merge 7 commits intopython-lsp:developfrom
Draft
Add basic Goto Implementation Request support#644smheidrich wants to merge 7 commits intopython-lsp:developfrom
smheidrich wants to merge 7 commits intopython-lsp:developfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As pointed out in #97, support for the LSP Goto Implementation Request (
textDocument/implementation) akaimplementationProvidercapability is still missing.This PR adds basic support for this feature using Rope's
rope.findit.find_implementationsfunction (so it only works if theropeextra is installed).Rope's
find_implementationsfunction seems a bit brittle, e.g. it doesn't appear to work for some slightly more complicated inheritance hierarchies (multiple levels & multiple inheritance & generics, but not sure which of these is the issue), but these things should be fixed upstream & in any case it's better than nothing.Status
findit.find_implementationson method call finds implementation for different subclass python-rope/rope#812