Skip to content

Add basic Goto Implementation Request support#644

Draft
smheidrich wants to merge 7 commits intopython-lsp:developfrom
smheidrich:implement-basic-goto-implementation
Draft

Add basic Goto Implementation Request support#644
smheidrich wants to merge 7 commits intopython-lsp:developfrom
smheidrich:implement-basic-goto-implementation

Conversation

@smheidrich
Copy link

@smheidrich smheidrich commented May 11, 2025

Description

As pointed out in #97, support for the LSP Goto Implementation Request (textDocument/implementation) aka implementationProvider capability is still missing.

This PR adds basic support for this feature using Rope's rope.findit.find_implementations function (so it only works if the rope extra is installed).

Rope's find_implementations function seems a bit brittle, e.g. it doesn't appear to work for some slightly more complicated inheritance hierarchies (multiple levels & multiple inheritance & generics, but not sure which of these is the issue), but these things should be fixed upstream & in any case it's better than nothing.

Status

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants