ci(release): make build-test-evidence non-blocking#272
Merged
Conversation
After #269 (wasm-component-ld) and #271 (lld/wasm-ld), the build-test- evidence job still fails: the spar wasm32-wasip2 build pulls in highs-sys (a C++ solver), whose CMake CXX-ABI probe needs a full WASI C/C++ SDK — wasm-ld can't find crt1.o, -lc, -lc++, -lc++abi, or libclang_rt.builtins-wasm32.a. The runner image no longer ships a wasi sysroot, and wiring in wasi-sdk is a bigger lift. The test-evidence bundle is a compliance artifact, not a user-facing binary. Mark the job continue-on-error so a failure doesn't skip Create GitHub Release — the release ships 8/9 assets (all binaries + vsix + compliance report + SHA256SUMS, minus rivet-vX.Y.Z-test-evidence.tar.gz). Restoring it properly (install wasi-sdk, set WASI_SDK_PATH) is tracked separately. Surfaced blocking the v0.9.0 release. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: df7779c | Previous: 56f5d0f | Ratio |
|---|---|---|---|
link_graph_build/10000 |
32720422 ns/iter (± 2134899) |
25363394 ns/iter (± 1506207) |
1.29 |
query/10000 |
159448 ns/iter (± 1520) |
121634 ns/iter (± 858) |
1.31 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v0.9.0 Release workflow has been blocked for several iterations by
build-test-evidence. After #269 (wasm-component-ld) and #271 (lld/wasm-ld), it still fails — the sparwasm32-wasip2build pulls inhighs-sys(a C++ solver), whose CMake CXX-ABI probe needs a full WASI C/C++ SDK:The runner image no longer ships a WASI sysroot, and wiring in
wasi-sdk(download,WASI_SDK_PATH, point clang at the sysroot) is a bigger lift than is worth blocking a release on. The test-evidence bundle is a compliance artifact, not a user-facing binary — all 5 binary archives + vsix + compliance report build fine.Fix:
continue-on-error: trueon thebuild-test-evidencejob. A failure no longer skipsCreate GitHub Release; the release ships 8/9 assets (missing onlyrivet-vX.Y.Z-test-evidence.tar.gz). Restoring it properly is tracked separately.After merge
v0.9.0tag at the new main HEAD to re-run the Release workflow.Test plan
Create GitHub Releaseruns even thoughbuild-test-evidencefails; v0.9.0 page gets 8 assetsrelease-npm.ymlauto-fires viaworkflow_run(validates ci(release-npm): switch to workflow_run trigger so npm publish auto-fires #261)npm view @pulseengine/rivet version→ 0.9.0🤖 Generated with Claude Code