Auto 'pretranspile' package on release creation#47
Conversation
DeeDeeG
left a comment
There was a problem hiding this comment.
Thank you for being so thoughtful / proactive as to make this into an automation!
My thoughts on looking this over, but thanks again for the work!
Credit goes to @mauricioszabo, figuring out how to do this was all him. I merely asked him how he did it and took notes, and the wrote it out in those commit messages as docs. I should have mentioned him as the source of info, but I am quick to remind folks and tell that part of the story if anyone implies I came up with it. (Which in hindsight it looks as if something I invented if you don't happen to know it was actually @mauricioszabo, so of course people think that! So I correct the record when it comes up.) |
Co-authored-by: DeeDeeG <DeeDeeG@users.noreply.github.com>
|
@DeeDeeG I was not aware that mauricio was the one to originally discover this! Good fun fact and shoutout |
DeeDeeG
left a comment
There was a problem hiding this comment.
Leaving the option to do this by posting a GitHub Release is no issue to me.
If I have a slight preference for doing it via manual dispatch, that option is enabled as well (thank you!).
Overall, LGTM!
|
@DeeDeeG Sorry, if you wouldn't mind taking one last look, I've made some changes:
This means we get complete automation, while leaving one tag for human consumption, and another for Pulsar consumption |
There was a problem hiding this comment.
Optional feedback about the automated commit message potentially including the version number, but it's exactly that, optional.
(Three proposals of how to address, only one (or none if not agreeing with the suggestion) needed, IDK why I went so far as to make three options, maybe just 'cause it's late lol.)
LGTM either way! Thank you for sticking through multiple rounds of review here, and for making this PR!
Co-authored-by: DeeDeeG <DeeDeeG@users.noreply.github.com>
Co-authored-by: DeeDeeG <DeeDeeG@users.noreply.github.com>
|
Thanks for all the review and getting this one past the finish line! Merging now |
Previously, to pretranspile a package it was a combination of dark arts and arcane magic thought up by the deranged, that was decoded by @mauricioszabo and later transcribed by @DeeDeeG.
Reference:
This PR aims to codify and automate it.
This PR adds a GHA workflow that on a release creation will automatically create a tag of the same version appended with
-pretranspile, to match our current conventions.Keeping with best practices of using our org defined NodeJS version that'll match Pulsar's current version, and unfortunately a hardcoded Electron version that we will have to keep updated with Pulsar, as well as lots of inspiration taken from our
pulsar-release-workflow,pulsar-chocolatey, andaction-pulsar-dependency, we should have something that "Just Works ™" here.Only real way to test it is to run it, so with the upcoming PR from @DeeDeeG to bump some dependencies to resolve issues I'm facing in
pulsar-edit/pulsar#1508, it'll be the perfect time to test.