Add a stored normalized name column with an index#1160
Merged
Conversation
gerrod3
reviewed
Mar 24, 2026
git-hyagi
force-pushed
the
pulp-python-high-db-load-issue
branch
from
2edeffd to
02d0537
Compare
git-hyagi
force-pushed
the
pulp-python-high-db-load-issue
branch
from
02d0537 to
53b6f61
Compare
jobselko
reviewed
Mar 25, 2026
git-hyagi
force-pushed
the
pulp-python-high-db-load-issue
branch
from
53b6f61 to
a6d943c
Compare
jobselko
reviewed
Mar 25, 2026
Contributor
jobselko
left a comment
jobselko
left a comment
There was a problem hiding this comment.
Partial review - I will look at viewsets.py tomorrow.
git-hyagi
force-pushed
the
pulp-python-high-db-load-issue
branch
from
a6d943c to
e8dcc19
Compare
jobselko
reviewed
Mar 26, 2026
jobselko
reviewed
Mar 26, 2026
pulp_python/app/migrations/0020_pythonpackagecontent_name_normalized.py
Outdated
Show resolved
Hide resolved
jobselko
approved these changes
Mar 26, 2026
Contributor
jobselko
left a comment
jobselko
left a comment
There was a problem hiding this comment.
Minor things, otherwise looks good!
Add a name_normalized field to PythonPackageContent that stores the pre-computed LOWER(REGEXP_REPLACE(name, ...)) value, populated via a BEFORE_SAVE hook. Add db_index=True. Change all name__normalize= lookups to use name_normalized__exact=. This eliminates the regex computation at query time. closes: pulp#1159 Assisted By: claude-opus-4.6
git-hyagi
force-pushed
the
pulp-python-high-db-load-issue
branch
from
e8dcc19 to
fe77dad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a name_normalized field to PythonPackageContent that stores the pre-computed LOWER(REGEXP_REPLACE(name, ...)) value, populated via a BEFORE_SAVE hook.
Add db_index=True.
Change all name__normalize= lookups to use name_normalized__exact=. This eliminates the regex computation at query time.
closes: #1159
Assisted By: claude-opus-4.6
📜 Checklist
See: Pull Request Walkthrough