feat: Add separate entry point for a Navigation API-driven router#139
Merged
rschristian merged 6 commits intomainfrom Apr 30, 2026
Merged
feat: Add separate entry point for a Navigation API-driven router#139rschristian merged 6 commits intomainfrom
rschristian merged 6 commits intomainfrom
Conversation
JoviDeCroock
approved these changes
Apr 15, 2026
| return { | ||
| url, | ||
| path, | ||
| query: Object.fromEntries(u.searchParams), |
Member
There was a problem hiding this comment.
We just need to add forward/back here
Member
Author
There was a problem hiding this comment.
Actually no, users are meant to use the global directly. We won't offer either utility.
preact-iso/test/router-navigation-api.test.js
Line 1020 in 39b1d16
Down the line the entire context can go away or just be kept internal, but that felt a bit breaking to do now. Would require users update a good size chunk of their apps, even if it's entirely opt-in.
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
rschristian
force-pushed
the
feat/navigation-api
branch
from
39b1d16 to
2295a6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#75, but non-breaking
Diff to existing router, types, and tests is actually super minimal, though obviously we don't see it here as these are all new files. Quite pleased.
CC @sbesh91