Skip to content

perf: replace manual fireEvent loop with shared wrapFireEventMethods #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lojhan merged 2 commits into from
Apr 5, 2026
Merged

perf: replace manual fireEvent loop with shared wrapFireEventMethods #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53b09e8
perf: replace manual fireEvent loop with shared wrapFireEventMethods
Lojhan Apr 5, 2026
76b4fdd
Merge branch 'main' into perf/testing-core-improvements
Lojhan Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 6 additions & 21 deletions deno.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 8 additions & 26 deletions src/react-testing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
createRenderMetricsEmitter,
createScreen,
getNow,
wrapFireEventMethods,
} from '@pokujs/dom';
import { parseRuntimeOptions } from './runtime-options.ts';

Expand Down Expand Up @@ -191,34 +192,15 @@ const wrappedFireEvent = ((...args: Parameters<typeof baseFireEvent>) => {
return result;
}) as typeof baseFireEvent;

for (const key of Object.keys(baseFireEventInstance) as Array<
keyof typeof baseFireEventInstance
>) {
const value = baseFireEventInstance[key];

if (typeof value !== 'function') {
(
wrappedFireEvent as unknown as Record<
keyof typeof baseFireEventInstance,
unknown
>
)[key] = value;
continue;
}

(
wrappedFireEvent as unknown as Record<
keyof typeof baseFireEventInstance,
unknown
>
)[key] = (...args: unknown[]) => {
wrapFireEventMethods(
wrappedFireEvent as unknown as Record<string, unknown>,
baseFireEventInstance as unknown as Record<string, unknown>,
(invoke: () => unknown) => {
let result: unknown;
act(() => {
result = Reflect.apply(value, baseFireEventInstance, args);
});
act(() => { result = invoke(); });
return result;
};
}
}
);

export const fireEvent = wrappedFireEvent;

Expand Down
Loading