Skip to content

Add notifier boolean configuration#7730

Merged
camdecoster merged 5 commits intoplotly:masterfrom
silversonicaxel:feature-notifier
Mar 25, 2026
Merged

Add notifier boolean configuration#7730
camdecoster merged 5 commits intoplotly:masterfrom
silversonicaxel:feature-notifier

Conversation

@silversonicaxel
Copy link

This PR is intended to allow the configuration for displaying or not the notifiers in the top - right area of the viewport.

This is related to the issue #7729 .

@camdecoster
Copy link
Contributor

@silversonicaxel would you be able to rebase your branch such that the linting changes are all in one commit? It makes it hard to review when they're all mixed in.

@silversonicaxel silversonicaxel force-pushed the feature-notifier branch 8 times, most recently from 2d5a55a to 0171b04 Compare March 24, 2026 07:07
@silversonicaxel
Copy link
Author

silversonicaxel commented Mar 24, 2026

@camdecoster

I undid most of them, (sorry I had global linter in the IDE)

But the last left, seem legit to me.

And project linting was not complaining, or fixing it in its execution.

    "lint": "npx @biomejs/biome lint",
    "lint-fix": "npx @biomejs/biome format ./test/image/mocks --write; npx @biomejs/biome lint --write || true",

@camdecoster
Copy link
Contributor

I'm totally fine with linting. It just helps to move all those changes into one commit, then make the actual PR changes in separate commits. I'll take a look at things right now, but you could make a final commit to lint after the review is complete.

Copy link
Contributor

@camdecoster camdecoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for me. You can add back your linting changes if you'd like.

@camdecoster
Copy link
Contributor

FYI, the test failures are unrelated to your changes.

@silversonicaxel
Copy link
Author

Working for me. You can add back your linting changes if you'd like.

I would prefer another PR, where lint rules are applied stricter. Otherwise I would feel to push my IDE lint rules to just a few bunch of files.

@camdecoster camdecoster merged commit 2dcd2c9 into plotly:master Mar 25, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants