Add notifier boolean configuration#7730
Conversation
|
@silversonicaxel would you be able to rebase your branch such that the linting changes are all in one commit? It makes it hard to review when they're all mixed in. |
2d5a55a to
0171b04
Compare
0171b04 to
5692404
Compare
|
I undid most of them, (sorry I had global linter in the IDE) But the last left, seem legit to me. And project linting was not complaining, or fixing it in its execution. |
|
I'm totally fine with linting. It just helps to move all those changes into one commit, then make the actual PR changes in separate commits. I'll take a look at things right now, but you could make a final commit to lint after the review is complete. |
camdecoster
left a comment
There was a problem hiding this comment.
Working for me. You can add back your linting changes if you'd like.
|
FYI, the test failures are unrelated to your changes. |
I would prefer another PR, where lint rules are applied stricter. Otherwise I would feel to push my IDE lint rules to just a few bunch of files. |
This PR is intended to allow the configuration for displaying or not the notifiers in the top - right area of the viewport.
This is related to the issue #7729 .