Open
Conversation
ShogunPanda
previously approved these changes
Mar 23, 2026
Member
|
One of the builds is failign |
- Add reusable build-and-test.yml workflow called by both CI and release - Add manual release.yml workflow with version/prerelease/skip-tests inputs - Simplify CI.yml to a thin wrapper - Add scripts/update-version.mjs for version bumping at release time CI fixes: - Use clang-16 (with LIBCLANG_PATH set to versioned .so.1) to avoid clang-14 emmintrin.h regression in node:22-slim - Cache key includes -llvm16 suffix to bust old clang-14 compiled cache - Run cargo test inside Docker to avoid root-owned target/ permissions - Use LD_PRELOAD to resolve PHP symbols in doctests (linker --as-needed drops libphp from DT_NEEDED) - Mark Embed::handle and lib.rs doctests as no_run to fix SIGSEGV from nested block_on in Drop impl Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Qard
force-pushed
the
triggered-releases
branch
from
4b76bcc to
3898245
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI.ymlinto a reusablebuild-and-test.yml(workflow_call) workflowbundlejob that assembles arelease-bundleartifact from all platform binaries + entrypointsCI.ymlto a thin wrapper that callsbuild-and-test.ymlrelease.ymlfor manualworkflow_dispatchreleases (replaces the auto-publish-on-commit-message pattern)scripts/update-version.mjsfor bumpingpackage.jsonversion at release timeKey changes vs old CI
release.ymlinstead of automatically on commit message pattern matchnpm-to support bundle job'spattern: npm-*downloadrelease.ymlusesNODE_AUTH_TOKENfromsetup-nodeinstead of manually configuringNPM_TOKENrelease.ymluses GitHub environmentnpm(matching python-node) for secrets scopingTest plan
npm-darwin-arm64andnpm-linux-x64-gnurelease-bundleartifact is assembled correctly in bundle jobscripts/update-version.mjslocally:node scripts/update-version.mjs 1.5.0release.ymlmanually via GitHub Actions UI after merging🤖 Generated with Claude Code