Revert 49b2ff5dbb94b76b265fd5909881997e1d95c6b3#21532
Open
Girgias wants to merge 1 commit intophp:PHP-8.4from
Open
Revert 49b2ff5dbb94b76b265fd5909881997e1d95c6b3#21532Girgias wants to merge 1 commit intophp:PHP-8.4from
Girgias wants to merge 1 commit intophp:PHP-8.4from
Conversation
ndossche
approved these changes
Mar 25, 2026
| @@ -0,0 +1,17 @@ | |||
| --TEST-- | |||
| GH-21499: RecursiveArrayIterator getChildren UAF after parent free | |||
Member
There was a problem hiding this comment.
Suggested change
| GH-21499: RecursiveArrayIterator getChildren UAF after parent free | |
| GH-21499 (RecursiveArrayIterator getChildren UAF after parent free) |
| ZVAL_NULL(ht_zv); | ||
| zval_ptr_dtor(¶ms[0]); | ||
| zend_string_free(Z_STR(function_name)); | ||
| zval_ptr_dtor(&function_name); |
Member
There was a problem hiding this comment.
This line could stay the same; or just use zval_ptr_dtor_str, doesn't matter too much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix for this was to take hold of a pointer of the bucket, something that should not be done as it causes memory corruptions
Up merge might be a PITA...