gen_stub: make use of PHP 8.0 and PHP 8.1 features (2)#21479
Open
DanielEScherzer wants to merge 3 commits intophp:masterfrom
Open
gen_stub: make use of PHP 8.0 and PHP 8.1 features (2)#21479DanielEScherzer wants to merge 3 commits intophp:masterfrom
DanielEScherzer wants to merge 3 commits intophp:masterfrom
Conversation
kocsismate
reviewed
Mar 20, 2026
In preparation for using constructor property promotion
DanielEScherzer
force-pushed
the
stub-new-php-features-2
branch
from
2ef58bc to
d1c47cc
Compare
TimWolla
reviewed
Mar 22, 2026
| private array $attributes; | ||
| private ?ExposedDocComment $exposedDocComment; | ||
| private bool $isNotSerializable; | ||
| /** @var Name[] */ |
Member
There was a problem hiding this comment.
With the move to CPP you lost the PHPDoc and thus the "generics".
Member
Author
There was a problem hiding this comment.
that information is still indicated in the parameter documentation in the constructor
kocsismate
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.1 has been required for the build system since #20933
Each commit can be reviewed independently, and should have no functional changes