remove correlation from oss

[nikhilsinhaparseable]

Summary by CodeRabbit

Release Notes

• Removed
  • Correlation feature completely removed from the system
  • All correlation REST API endpoints (list, create, get, update, delete) are no longer available
  • Correlation data management and storage operations have been removed

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b088e072-372a-4724-8713-0cd5b10787b5

📥 Commits

Reviewing files that changed from the base of the PR and between 79656f6 and 1487296.

📒 Files selected for processing (11)

• src/correlation.rs
• src/handlers/http/correlation.rs
• src/handlers/http/mod.rs
• src/handlers/http/modal/mod.rs
• src/handlers/http/modal/query_server.rs
• src/handlers/http/modal/server.rs
• src/handlers/http/users/mod.rs
• src/lib.rs
• src/metastore/metastore_traits.rs
• src/metastore/metastores/object_store_metastore.rs
• src/prism/home/mod.rs

💤 Files with no reviewable changes (9)

• src/lib.rs
• src/handlers/http/users/mod.rs
• src/handlers/http/mod.rs
• src/handlers/http/modal/query_server.rs
• src/handlers/http/modal/server.rs
• src/metastore/metastores/object_store_metastore.rs
• src/metastore/metastore_traits.rs
• src/handlers/http/correlation.rs
• src/correlation.rs

---

Walkthrough

This PR removes the entire correlation feature from the codebase, including the core data structures and validation logic, all HTTP endpoints for CRUD operations, HTTP route registration, metastore trait methods and implementations, and integration points with the home response generator.

Changes

Cohort / File(s)	Summary
Core correlation module src/correlation.rs	Deleted the entire module containing CorrelationConfig, CorrelationError, validation logic, in-memory cache (CORRELATIONS), and all CRUD operations (load, list, get, create, update, delete).
HTTP handlers and routing src/handlers/http/correlation.rs, src/handlers/http/mod.rs, src/handlers/http/modal/server.rs, src/handlers/http/modal/query_server.rs	Removed all correlation HTTP endpoint handlers (list, get, post, modify, delete), module declaration, and webscope route registration from the HTTP server configuration.
Module exports src/lib.rs	Removed public module declaration pub mod correlation; from crate root.
Metastore trait and implementation src/metastore/metastore_traits.rs, src/metastore/metastores/object_store_metastore.rs	Removed correlation-related trait methods (get_correlations, put_correlation, delete_correlation) from Metastore trait and their ObjectStoreMetastore implementations.
Initialization and home response src/handlers/http/modal/mod.rs, src/prism/home/mod.rs	Removed CORRELATIONS load task from concurrent initialization; removed correlation resource generation, resource type variant, and error variant from home response builder.
Configuration constants src/handlers/http/users/mod.rs	Removed CORRELATION_DIR public constant definition.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Feat: Metastore #1424 — Modifies correlation persistence and metastore APIs that are now being completely removed.
• fix multiple versions of rustls #1513 — Updates ResponseError/StatusCode imports in correlation-related code that is now deleted.
• Updates for Prism #1224 — Also modifies prism/home/mod.rs to alter correlation handling in home response generation.

Suggested reviewers

• parmesant
• nitisht

Poem

🐰 With whiskers twitched and coding flair,
We've swept the correlations clean from air!
Five endpoints gone, the cache removed,
Our codebase simpler, feature improved! ✨
Homeward bound through cleaner halls we bound! 🏃‍♂️

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request has no description provided, missing all required template sections including issue reference, description, and testing/documentation checklist.	Add a comprehensive description including the issue number, explanation of changes, rationale, and completion of the testing/documentation checklist items.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'remove correlation from oss' directly summarizes the main change: deletion of correlation functionality from the open-source codebase.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}