Skip to content

refactor: Bump eslint from 9.39.2 to 10.1.0#841

Merged
mtrezza merged 1 commit intoparse-community:masterfrom
mtrezza:refactor/eslint-10.1.0
Mar 31, 2026
Merged

refactor: Bump eslint from 9.39.2 to 10.1.0#841
mtrezza merged 1 commit intoparse-community:masterfrom
mtrezza:refactor/eslint-10.1.0

Conversation

@mtrezza
Copy link
Copy Markdown
Member

@mtrezza mtrezza commented Mar 31, 2026

Summary

Upgrades ESLint and related packages:

Package From To
eslint 9.39.2 10.1.0
@eslint/js 9.39.2 10.0.1

Also removes @babel/eslint-parser which was an unused devDependency with an incompatible peer dependency that blocks eslint 10.

Closes #837
Closes #836

Summary by CodeRabbit

  • Chores
    • Updated development toolchain dependencies to latest versions, including upgrades to linting and code analysis tools for improved compatibility and performance.

@parse-github-assistant
Copy link
Copy Markdown

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

  • Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
  • Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
  • Group code into logical blocks. Add a short comment before each block to explain its purpose.
  • We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
  • Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
  • Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 31, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0eee170d-f228-43fe-90ef-90765384cd8a

📥 Commits

Reviewing files that changed from the base of the PR and between 8896fd9 and e6e31bd.

📒 Files selected for processing (2)
  • package-lock.json
  • package.json

📝 Walkthrough

Walkthrough

Development toolchain dependencies upgraded: ESLint from 9.39.2 to 10.1.0, @eslint/js from 9.39.2 to 10.0.1, and removed @babel/eslint-parser. Package-lock.json reflects corresponding transitive ESLint ecosystem updates.

Changes

Cohort / File(s) Summary
Core ESLint Dependencies
package.json
Removed @babel/eslint-parser@7.28.6; upgraded eslint to 10.1.0 and @eslint/js to 10.0.1.
Lockfile Resolution
package-lock.json
Updated transitive dependency graph for ESLint v10 ecosystem: replaced/upgraded @eslint/* packages, eslint-scope, eslint-visitor-keys, espree, and other transitive dependencies; removed older v9-specific packages.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • PR #827: Coordinates ESLint v10 adoption by bumping @typescript-eslint to v8.56.0, which adds ESLint v10 support compatibility.
🚥 Pre-merge checks | ✅ 6 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Engage In Review Feedback ❓ Inconclusive GitHub pull request reviews and discussions are not accessible through repository files or git history, making it impossible to verify engagement with review feedback. Provide the GitHub PR discussion thread, review comments section, or a summary of reviewer feedback and user responses to assess this check.
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'refactor: Bump eslint from 9.39.2 to 10.1.0' follows the required prefix format and clearly describes the main change of upgrading ESLint.
Linked Issues check ✅ Passed The PR successfully upgrades eslint to 10.1.0 and @eslint/js to 10.0.1, meeting the primary objectives from #837 and #836, and removes @babel/eslint-parser to resolve the peer dependency conflict blocking ESLint 10.
Out of Scope Changes check ✅ Passed All changes are directly related to the ESLint upgrade objectives: dependency version bumps in package.json and package-lock.json, with removal of the incompatible @babel/eslint-parser package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Security Check ✅ Passed Pull request removes unused @babel/eslint-parser dependency and upgrades eslint to 10.1.0 and @eslint/js to 10.0.1 with security fixes for ajv, minimatch, and transitive dependencies.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.2.510)
package.json

2026-03-31 16:28:20,949 [MainThread ] [ERROR] Template file not found: package.json
2026-03-31 16:28:20,955 [MainThread ] [ERROR] Template file not found: package.json
2026-03-31 16:28:20,957 [MainThread ] [ERROR] Template file not found: package.json
2026-03-31 16:28:21,004 [MainThread ] [ERROR] Failed to invoke function /usr/local/lib/python3.11/dist-packages/checkov/common/runners/object_runner. with package.json
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/checkov/common/parallelizer/parallel_runner.py", line 88, in func_wrapper
result = original_func(item)
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/checkov/common/runners/object_runner.py", line 74, in
results = parallel_runner.run_function(lambda f: (f, self._parse_file(f)), files_to_load)
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/checkov/ope

... [truncated 2547 characters] ...

[MainThread ] [WARNI] Secret scanning: could not process file package.json
2026-03-31 16:28:21,043 [MainThread ] [ERROR] Exception traceback:
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/checkov/main.py", line 647, in run
self.scan_reports = runner_registry.run(
^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/checkov/common/runners/runner_registry.py", line 177, in run
for result in parallel_runner_results:
File "/usr/local/lib/python3.11/dist-packages/checkov/common/parallelizer/parallel_runner.py", line 118, in _run_function_multiprocess_fork
raise v.internal_exception.with_traceback(v.internal_exception.traceback)
FileNotFoundError: [Errno 2] No such file or directory: 'package.json'


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mtrezza mtrezza merged commit ea57e40 into parse-community:master Mar 31, 2026
4 checks passed
@mtrezza mtrezza deleted the refactor/eslint-10.1.0 branch March 31, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant