fix(client/utils): Fix sprites not showing correctly#188
Open
thaibossaw wants to merge 1 commit intooverextended:mainfrom
Open
fix(client/utils): Fix sprites not showing correctly#188thaibossaw wants to merge 1 commit intooverextended:mainfrom
thaibossaw wants to merge 1 commit intooverextended:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, ox_target limits the number of sprites being drawn per-frame using the literal value of the
ox_target:drawSpriteConvar. This is misleading, as the docs indicate the convar is simply used to toggle the drawing on/off, but what it's actually doing is limiting the number of sprites that can be drawn per frame, here:ox_target/client/utils.lua
Line 36 in 6ee2b5a
ox_target/client/utils.lua
Line 70 in 6ee2b5a
This is because we set the value of
drawZoneSpritesto be the exact value of the Convar, meaning if you set the convar to be1, you end up with an odd behaviour where some sprites within range of other sprites will never show at the same time. See repro in video(s) below:https://discord.com/channels/813030955598086174/1358472533409534255/1358474412336091187
https://discord.com/channels/813030955598086174/1358472533409534255/1358474678913470645
Looking at the default value for the convar when no value is set, it assumes a value of 24, so it stands to reason that if the convar is set to 1, we should probably set
drawZoneSpritesto be 24.