Allow a delay for a service to be present in the remote test container before installing the test probe#49
Allow a delay for a service to be present in the remote test container before installing the test probe#49lanouettea wants to merge 2 commits intoops4j:masterfrom
Conversation
…r before installing the test probe This modification can allow specific scenarios where a specialized service is registered to indicate that the framework is ready for the test. This can be especially useful for tests using blueprint or test using bundles that load other bundles in the container without being explicitely in the boot features defined by the pax exam test.
|
Hi, first of all thanks for providing a pull request. Now let's get down to business. Could you please take a look at the Contributing section of the README.md
Regarding the last point, in this fix the imports do look like they violate that. |
|
Thank you for the feedback Achim. Apparently, my IDE (IntelliJ) has rearranged import and reformatted the code. I believed I fixed those scrambles before commiting. I will review everything and submit a new commit with correct code formatting and a valid test case. Do you have an intelliJ formatter available as well? |
|
Hi, I'm not aware of a intelliJ formating file, feel free to do a pull request for that also :) regards, Achim |
|
|
||
| /** | ||
| * Per default the folder pax-exam is deleting the test directories after a test is over. If you want to keep those | ||
| * directories (for later evaluation) simply set this option. |
There was a problem hiding this comment.
this JavaDoc seems to be copy-pasted from another option, and should be adjusted to described this new option instead.
This modification can allow specific scenarios where a specialized
service is registered to indicate that the framework is ready for the
test. This can be especially useful for tests using blueprint or test
using bundles that load other bundles in the container without being
explicitely in the boot features defined by the pax exam test.