Fix the unit test failures of pax-exam-container-forked on windows#1139
Open
glimmerveen wants to merge 1 commit intoops4j:v4.xfrom
Open
Fix the unit test failures of pax-exam-container-forked on windows#1139glimmerveen wants to merge 1 commit intoops4j:v4.xfrom
glimmerveen wants to merge 1 commit intoops4j:v4.xfrom
Conversation
Member
|
@glimmerveen, Thanks for investigating and fixing! I didn't face such problems with System Lambda in a similar setup. |
…able through surefire configuration. The EnvironmentVariablesRule's manipulation of the ProcessEnvironment does not work together with the JVM on windows.
glimmerveen
force-pushed
the
fix-failing-tests-on-windows
branch
from
dd28f8f to
ca64da4
Compare
Contributor
Author
I have rebased and signed my commit. |
Contributor
Author
|
@oliverlietz is there anything holding back the merge of this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced EnvironmentVariablesRule with supplying the environment variable through surefire configuration. The EnvironmentVariablesRule's manipulation of the ProcessEnvironment does not work together with the JVM on windows.