Skip to content

[chore] add tsconfig to wikis module#22587

Merged
Kharonus merged 1 commit intodevfrom
chore/add-tsconfig-to-wikis-module
Apr 10, 2026
Merged

[chore] add tsconfig to wikis module#22587
Kharonus merged 1 commit intodevfrom
chore/add-tsconfig-to-wikis-module

Conversation

@Kharonus
Copy link
Copy Markdown
Member

What are you trying to accomplish?

  • use my IDE without red lines everywhere

What approach did you choose and why?

  • needed to tell IDEs to lookup the lookup paths
  • doesn't affect build, as the tsconfig.json in the module directory should be ignored by esbuild of the core app.

- needed to tell IDEs to lookup the lookup paths
- doesn't affect build, as the `tsconfig.json` in the module directory
  should be ignored by esbuild of the core app.
@Kharonus Kharonus requested a review from a team March 30, 2026 12:33
@Kharonus Kharonus self-assigned this Mar 30, 2026
@myabc myabc requested a review from Copilot April 6, 2026 14:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a local TypeScript configuration for the Wikis frontend module to improve IDE typechecking/path resolution without impacting the core app’s esbuild build.

Changes:

  • Add modules/wikis/frontend/tsconfig.json extending the main frontend tsconfig.json with module-specific lookup settings.
  • Minor import/whitespace adjustments in Wikis module Angular files (no behavioral changes).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
modules/wikis/frontend/tsconfig.json Introduces a module-local tsconfig extending the core frontend tsconfig for IDE support.
modules/wikis/frontend/module/wikis-tab/wikis-tab.component.ts Whitespace-only change (import section formatting).
modules/wikis/frontend/module/main.ts Reorders imports and adds spacing in the module entry file.

Comment on lines +6 to +8
"../../../frontend/node_modules/@types",
"../../../frontend/node_modules"
]
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typeRoots should only point at directories that directly contain type packages (typically .../node_modules/@types). Adding .../node_modules is unlikely to help (scoped packages like @angular/* won’t be discovered as global type packages) and can significantly slow down TS server by scanning all dependencies. If the goal is to resolve regular package imports from frontend/node_modules, prefer keeping typeRoots limited to .../node_modules/@types and add an explicit compilerOptions.paths fallback (e.g., mapping * to node_modules/*) or another approach that targets module resolution rather than global type roots.

Suggested change
"../../../frontend/node_modules/@types",
"../../../frontend/node_modules"
]
"../../../frontend/node_modules/@types"
],
"paths": {
"*": [
"node_modules/*"
]
}

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get it, if I want imports like import { CUSTOM_ELEMENTS_SCHEMA, Injector, NgModule } from '@angular/core'; being resolved in this directory, I need the classes defined in the node_modules from the root app.

I do not have any node_modules installed in the wiki module sub path.

@myabc
Copy link
Copy Markdown
Contributor

myabc commented Apr 6, 2026

@Kharonus ideally this would be fixed globally - for all modules including modules/gitlab_integration/frontend and modules/github_integration/frontend.

@Kharonus
Copy link
Copy Markdown
Member Author

yes, ideally. I have no solution in my pocket directly, and I'd like to continue coding in the new wikis module asap. Hence, I'd like to merge that PR as is. And find a general solution later.

@Kharonus Kharonus merged commit ecda72d into dev Apr 10, 2026
20 of 22 checks passed
@Kharonus Kharonus deleted the chore/add-tsconfig-to-wikis-module branch April 10, 2026 13:27
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants