Render turbo error flash for failed project custom field section actions#22583
Open
MASTERMINDftw wants to merge 5 commits intoopf:devfrom
Open
Render turbo error flash for failed project custom field section actions#22583MASTERMINDftw wants to merge 5 commits intoopf:devfrom
MASTERMINDftw wants to merge 5 commits intoopf:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
No ticket linked.
What are you trying to accomplish?
This PR adds turbo-stream error feedback for failed admin project custom field section actions.
Previously, failed
destroy,move, anddropactions inAdmin::Settings::ProjectCustomFieldSectionsControllerdid not show a user-visible error in the UI.Screenshots
No screenshots attached. This change affects turbo-stream flash behavior for failure cases.
What approach did you choose and why?
I followed the existing turbo-stream error handling pattern already used in neighboring admin controllers.
Instead of leaving the failure branches empty, the controller now renders an error flash via
render_error_flash_message_via_turbo_stream(...)using joined service error messages. I also added focused controller specs for the failure paths.This keeps the change small, consistent with the surrounding code, and improves admin feedback without changing the successful flow.
Merge checklist