Skip to content

feat(charts): add rhoso-apps helm chart and ci#40

Merged
cjeanner merged 1 commit into
mainfrom
feature/rhoso-apps-helm-chart
May 11, 2026
Merged

feat(charts): add rhoso-apps helm chart and ci#40
cjeanner merged 1 commit into
mainfrom
feature/rhoso-apps-helm-chart

Conversation

@cjeanner
Copy link
Copy Markdown
Collaborator

Add Helm chart for Argo CD Applications (templates, values, values.schema.json), and a path-filtered GitHub Actions workflow (lint, template, package) with a TODO for publishing release artifacts.

Refs: https://redhat.atlassian.net/browse/OSPRH-27658

AI-Assist: Cursor; model=Composer-2; mode=agent; origin=cursor
Made-with: Cursor

@cjeanner cjeanner force-pushed the feature/rhoso-apps-helm-chart branch 2 times, most recently from b9f3fc6 to 3f7a761 Compare March 24, 2026 12:59
@cjeanner cjeanner marked this pull request as ready for review March 24, 2026 13:01
@cjeanner cjeanner marked this pull request as draft March 24, 2026 13:01
@cjeanner cjeanner self-assigned this Mar 24, 2026
@cjeanner cjeanner force-pushed the feature/rhoso-apps-helm-chart branch 10 times, most recently from cc0e53a to fc5e20e Compare April 7, 2026 06:47
Copy link
Copy Markdown
Contributor

@holser holser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall It looks good to me.

@holser holser self-requested a review April 8, 2026 17:52
Comment thread applications/vault-secrets-operator.yaml Outdated
@cjeanner cjeanner force-pushed the feature/rhoso-apps-helm-chart branch 3 times, most recently from 6d7161a to b62fafd Compare April 20, 2026 11:26
@cjeanner cjeanner marked this pull request as ready for review April 20, 2026 11:28
@cjeanner cjeanner requested review from holser and pinikomarov April 20, 2026 11:29
@cjeanner cjeanner force-pushed the feature/rhoso-apps-helm-chart branch 2 times, most recently from 0d311c5 to d6a6b38 Compare April 20, 2026 13:22
holser
holser previously approved these changes Apr 20, 2026
Copy link
Copy Markdown
Contributor

@holser holser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Comment thread charts/rhoso-apps/values.yaml
Comment thread charts/rhoso-apps/templates/_helpers.tpl Outdated
Comment thread charts/rhoso-apps/templates/application.yaml Outdated
Comment thread .github/workflows/helm-chart.yml Outdated
Comment thread .github/workflows/helm-chart.yml Outdated
Comment thread charts/rhoso-apps/Chart.yaml Outdated
Comment thread charts/rhoso-apps/README.md
Comment thread charts/rhoso-apps/Chart.yaml
Comment thread charts/rhoso-apps/README.md
@pinikomarov
Copy link
Copy Markdown
Contributor

overall looks ok

@cjeanner cjeanner force-pushed the feature/rhoso-apps-helm-chart branch from d6a6b38 to b350046 Compare April 22, 2026 07:55
@cjeanner cjeanner requested a review from aharivel April 22, 2026 07:56
@cjeanner cjeanner force-pushed the feature/rhoso-apps-helm-chart branch 2 times, most recently from e610986 to 0d566d4 Compare April 22, 2026 08:18
@cjeanner cjeanner requested a review from pinikomarov April 22, 2026 09:16
@cjeanner cjeanner enabled auto-merge (squash) May 7, 2026 11:24
@cjeanner cjeanner disabled auto-merge May 7, 2026 11:24
@pinikomarov
Copy link
Copy Markdown
Contributor

codeflow looks ok

Add Helm chart for Argo CD Applications (templates, values,
values.schema.json), and a path-filtered GitHub Actions workflow
(lint, template, package) with a TODO for publishing release
artifacts.

Refs: https://redhat.atlassian.net/browse/OSPRH-27658

AI-Assist: Cursor; model=Composer-2; mode=agent; origin=cursor
Made-with: Cursor
@cjeanner cjeanner force-pushed the feature/rhoso-apps-helm-chart branch from 0d566d4 to 544da5e Compare May 11, 2026 13:11
Copy link
Copy Markdown

@aharivel aharivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjeanner cjeanner merged commit 26a8e5f into main May 11, 2026
2 checks passed
@cjeanner cjeanner deleted the feature/rhoso-apps-helm-chart branch May 11, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants