[pcp_metrics] Fix broken hosts selection#3928
Merged
openshift-merge-bot[bot] merged 1 commit intoMay 13, 2026
Merged
Conversation
Because `cifmw_pcp_metrics_hosts` was defined in the pcp_metrics role's defaults file, the `pcp-metrics-pre.yml` playbook was trying use to this var before it was imported, leading to `'cifmw_pcp_metrics_hosts' is undefined` errors Signed-off-by: Michael Burke <michburk@redhat.com>
rebtoor
approved these changes
May 13, 2026
Contributor
|
thanks @michburk , i definitely missed it! |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebtoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
To be fair, I also missed this when reviewing the pr 😅 |
Contributor
Author
|
Tested and working downstream in testproject 2296 |
03e101e
into
openstack-k8s-operators:main
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
cifmw_pcp_metrics_hostswas defined in the pcp_metrics role's defaults file, thepcp-metrics-pre.ymlplaybook was trying to use this var before it was imported, leading to'cifmw_pcp_metrics_hosts' is undefinederrors