Skip to content

[pcp_metrics] Fix broken hosts selection#3928

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
michburk:pcp-hosts-fix
May 13, 2026
Merged

[pcp_metrics] Fix broken hosts selection#3928
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
michburk:pcp-hosts-fix

Conversation

@michburk
Copy link
Copy Markdown
Contributor

@michburk michburk commented May 13, 2026

Because cifmw_pcp_metrics_hosts was defined in the pcp_metrics role's defaults file, the pcp-metrics-pre.yml playbook was trying to use this var before it was imported, leading to 'cifmw_pcp_metrics_hosts' is undefined errors

@michburk michburk requested review from a team and rebtoor May 13, 2026 14:29
Because `cifmw_pcp_metrics_hosts` was defined in the pcp_metrics role's
defaults file, the `pcp-metrics-pre.yml` playbook was trying use to this
var before it was imported, leading to `'cifmw_pcp_metrics_hosts' is
undefined` errors

Signed-off-by: Michael Burke <michburk@redhat.com>
@rebtoor
Copy link
Copy Markdown
Contributor

rebtoor commented May 13, 2026

thanks @michburk , i definitely missed it!

@rebtoor
Copy link
Copy Markdown
Contributor

rebtoor commented May 13, 2026

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michburk
Copy link
Copy Markdown
Contributor Author

thanks @michburk , i definitely missed it!

To be fair, I also missed this when reviewing the pr 😅

@michburk
Copy link
Copy Markdown
Contributor Author

Tested and working downstream in testproject 2296

PLAY [Start collecting performance metrics] ************************************

TASK [Setup PCP name=pcp_metrics, tasks_from=setup] ****************************
Wednesday 13 May 2026  15:47:59 +0000 (0:00:00.542)       0:00:02.711 *********
Wednesday 13 May 2026  15:47:59 +0000 (0:00:00.542)       0:00:02.710 *********

TASK [pcp_metrics : Install PCP name={{ pcp_metrics_packages }}, state=present, use=ansible.builtin.dnf] ***
Wednesday 13 May 2026  15:47:59 +0000 (0:00:00.093)       0:00:02.804 *********
Wednesday 13 May 2026  15:47:59 +0000 (0:00:00.093)       0:00:02.803 *********
changed: [ocp-master-2]
changed: [ocp-master-0]
changed: [ocp-master-1]
changed: [controller-0]
ok: [hypervisor]
changed: [compute-94-b34mesey-0]
changed: [compute-96-b34mesey-0]

@openshift-merge-bot openshift-merge-bot Bot merged commit 03e101e into openstack-k8s-operators:main May 13, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants