[build_containers] Fix podman_image push dest for FQDN image names#3923
[build_containers] Fix podman_image push dest for FQDN image names#3923danpawlik wants to merge 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
danpawlik
force-pushed
the
do-not-use-item
branch
8 times, most recently
from
d4fabff to
07453e7
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 12m 44s |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 27m 31s |
danpawlik
force-pushed
the
do-not-use-item
branch
from
07453e7 to
88d50b7
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 15m 30s |
danpawlik
force-pushed
the
do-not-use-item
branch
3 times, most recently
from
beb56d5 to
8784cac
Compare
danpawlik
changed the title
danpawlik
force-pushed
the
do-not-use-item
branch
from
8784cac to
a0c01ac
Compare
danpawlik
force-pushed
the
do-not-use-item
branch
from
a0c01ac to
8e574c2
Compare
The containers-built.log contains a list of images as registry/namespace/repository.
The containers.podman.podman_image module treats a two-part dest (host/namespace)
as a prefix and appends the entire local image name, which produced nested
repo names on quay.rdoproject.org.
Pass a complete dest (registry, namespace, repository basename, and tag)
so Podman pushes to the intended repository.
Commit also include a changes that remove calling {{ item }} when
loop is used and reduce using `cat` command with `grep` - we can directly
call `grep` without `cat`.
One more change also done in this commit was to rename tasks that
contains wrong script name, that makes confusion.
Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
danpawlik
force-pushed
the
do-not-use-item
branch
from
8e574c2 to
f6df298
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 11m 02s |
amoralej
left a comment
amoralej
left a comment
There was a problem hiding this comment.
LGTM. Tested in https://review.rdoproject.org/r/c/testproject/+/58840
2 participants
The containers-built.log contains a list of images as registry/namespace/repository.
The containers.podman.podman_image module treats a two-part dest (host/namespace)
as a prefix and appends the entire local image name, which produced nested
repo names on quay.rdoproject.org.
Pass a complete dest (registry, namespace, repository basename, and tag)
so Podman pushes to the intended repository.
Commit also include a changes that remove calling {{ item }} when
loop is used and reduce using
catcommand withgrep- we can directlycall
grepwithoutcat.One more change also done in this commit was to rename tasks that
contains wrong script name, that makes confusion.