[env_op_images] Add unit tests for verify_pulled_report_crio#3914
[env_op_images] Add unit tests for verify_pulled_report_crio#3914nemarjan wants to merge 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
recheck |
1 similar comment
|
recheck |
ad595db to
b32c182
Compare
evallesp
left a comment
There was a problem hiding this comment.
LGTM in general, some questions.
b32c182 to
2371b09
Compare
f29c7d2 to
cdc44cd
Compare
|
recheck |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 11m 28s |
Add focused unit coverage for CRI-O pulled report verification, including successful enrichment, cross-node evidence accounting, and failure when no logs are provided. Reuse shared test utilities with a local fallback so tests run in both collection-style and local environments. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: nemarjan <nemarjan@redhat.com>
cdc44cd to
ef38a7e
Compare
michburk
left a comment
There was a problem hiding this comment.
Changes lgtm, but I do have one critique that isn't necessarily blocking:
It looks like this pr is making two changes:
- Add the unit tests
- Move the verify_pulled_report_crio.py file and use the fcqn for
verify_pulled_report_crio
This isn't a huge set of changes, but I think generally we should keep commits focused on one set of changes at a time. For example, in the event we need to revert something, we can create one revert commit that can specifically target the exact broken changes, rather than trying to de-tangle a smaller subset of changes from a larger commit.
Add focused unit coverage for CRI-O pulled report verification, including successful enrichment, cross-node evidence accounting, and failure when no logs are provided. Reuse shared test utilities with a local fallback so tests run in both collection-style and local environments.
Assisted-By: Cursor Code