Skip to content

[WIP] MPIIT: Update Owned Views#3535

Open
oharan2 wants to merge 5 commits into
openshift:mainfrom
oharan2:views
Open

[WIP] MPIIT: Update Owned Views#3535
oharan2 wants to merge 5 commits into
openshift:mainfrom
oharan2:views

Conversation

@oharan2
Copy link
Copy Markdown
Contributor

@oharan2 oharan2 commented May 18, 2026

Main changes:

1. The existing LP interop views are renamed (*-LP-Interop*-LP-OCP-Compat).

Filters, releases, and LayeredProduct lists are unchanged—only the view names change.

2. New 5.0 onboarding views. Two new views are added for upcoming component registration (5.0 only):

5.0-LP-Interop— shell for general LP interop onboarding (LayeredProduct: [])
5.0-LP-Chaos — shell for chaos-engineering LP components (LayeredProduct: [])

Both mirror 5.0-LP-OCP-Compat (same base/sample releases, grouping, Network/Owner filters, advanced options) but start with an empty product list so components can be added incrementally per the onboarding workflow.

3. Regression tracking

To ensure the best practices (i.e., sync the regression data back to the DB instead of just on the Sippy end), regression_tracking.enabled: true is set on mpex-owned LP views.

4. Organization level Ownership

Update all mpiit (team scope) owned views to be registered under mpex (org scope).

Summary by CodeRabbit

  • Chores
    • Added OCP-Compat test view entries for 5.0, 4.22, 4.21 and 4.20.
    • Enabled regression tracking for the new compatibility views.
    • Adjusted variant filtering/tracking behavior for compatibility-focused views.
    • Updated owner assignment for the compatibility views.
  • New Features
    • Added a 5.0 "Chaos" compatibility view to support network-focused testing.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

Walkthrough

Rename LP-Interop views to LP-OCP-Compat for releases 5.0, 4.22, 4.21, 4.20; add a 5.0-LP-Chaos view; adjust variant filters and enable regression tracking; update variant owner inference from mpiit to mpex and update the test expectation.

Changes

Views and Variant Registry

Layer / File(s) Summary
5.0 Release View Changes
config/views.yaml
Rename 5.0-LP-Interop to 5.0-LP-OCP-Compat; set LayeredProduct: [], change Owner to mpex, enable regression_tracking; add 5.0-LP-Chaos with LayeredProduct: [], Network: [ovn], same owners, and regression_tracking.enabled: true.
4.22, 4.21, 4.20 Release View Updates
config/views.yaml
Rename 4.x-LP-Interop to 4.x-LP-OCP-Compat for 4.22, 4.21, 4.20; update Owner entries from mpiit to mpex and set regression_tracking.enabled: true for each.
Variant registry and tests
pkg/variantregistry/ocp.go, pkg/variantregistry/ocp_test.go
Update owner inference for -lp-interop jobs: VariantOwner resolves to mpex (was mpiit) and update TestVariantSyncer expected VariantOwner accordingly.

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 16 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (16 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Go Error Handling ✅ Passed PR contains only simple string value updates (mpiit→mpex) with no error handling code changes. No panic calls, ignored errors, or unsafe pointer dereferences.
Sql Injection Prevention ✅ Passed No SQL injection vulnerabilities introduced. Changes are variant owner mapping updates only. No SQL query construction code modified. Parameterization remains properly implemented.
Excessive Css In React Should Use Styles ✅ Passed Custom check not applicable: PR modifies only Go (.go) and YAML (.yaml) files. No React/JSX components exist in the repository, and the check targets React inline CSS violations only.
Test Coverage For New Features ✅ Passed Configuration changes are exempt. Code changes update existing behavior. Existing TestVariantSyncer covers the modified ocp.go function.
Single Responsibility And Clear Naming ✅ Passed PR complies with Single Responsibility and Clear Naming principles. No new types/functions; changes maintain clear, action-oriented naming and focused responsibilities throughout.
Stable And Deterministic Test Names ✅ Passed Repository does not use Ginkgo testing framework. No Ginkgo test names found. Uses table-driven testing instead. Check not applicable.
Test Structure And Quality ✅ Passed PR modifies only test data (expected value), not test structure. No new Ginkgo tests added. The codebase uses standard Go testing with testify, not Ginkgo. Check is not applicable.
Microshift Test Compatibility ✅ Passed No Ginkgo e2e tests added. PR only modifies config/views.yaml and variant registry code with standard Go unit tests. Check not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR does not add Ginkgo e2e tests. Changes include config updates and standard Go unit test updates only, which are not subject to SNO compatibility checks.
Topology-Aware Scheduling Compatibility ✅ Passed Check applies only to deployment manifests, operators, or controllers. PR modifies CI test config and variant registry code only.
Ote Binary Stdout Contract ✅ Passed PR modifies config file, variant ownership mapping, and test expectations. No main/init/TestMain/suite setup functions present. No stdout writes, logging config, or output code changes detected.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Custom check applies only to new Ginkgo e2e tests. PR contains config updates, variant registry code changes, and Go unit tests—no Ginkgo e2e tests added.
Title check ✅ Passed The title mentions updating MPIIT-owned views, which aligns with the main objective of changing ownership from mpiit to mpex and renaming LP-Interop views to LP-OCP-Compat. However, the [WIP] prefix indicates work-in-progress status, and the title is somewhat vague about the specific changes (renaming views and ownership updates).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from deepsm007 and smg247 May 18, 2026 10:07
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oharan2
Once this PR has been reviewed and has the lgtm label, please assign xueqzhan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label May 18, 2026
@oharan2
Copy link
Copy Markdown
Contributor Author

oharan2 commented May 18, 2026

/test security

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

Comment thread config/views.yaml Outdated
@oharan2 oharan2 requested a review from etirta May 18, 2026 18:41
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 18, 2026

@oharan2: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 2587974 link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@oharan2 oharan2 changed the title MPIIT: Update Owned Views [WIP] MPIIT: Update Owned Views May 18, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants