[WIP] SPLAT-2526: Refactor openshift-tests-ext#1427
Draft
vr4manta wants to merge 6 commits into
Draft
Conversation
openshift-ci-robot
added
the
jira/valid-reference
Contributor
|
@vr4manta: This pull request references SPLAT-2526 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
Skipping CI for Draft Pull Request. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
Contributor
Author
|
/test e2e-aws-ovn |
vr4manta
changed the title
Member
|
I think openshift-eng/openshift-tests-extension#44 fixes the original source of your problem. Your original PR if it included that PR, would've worked fine. Without it, you're pulling in thousands of kube tests. |
openshift-merge-robot
added
the
needs-rebase
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
Bot
added
the
lifecycle/stale
Contributor
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
Bot
added
lifecycle/rotten
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThis PR restructures the repository into a Go workspace with a dedicated ChangesGo Workspace Refactoring
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes 🚥 Pre-merge checks | ✅ 9 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (9 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
Contributor
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
Author
|
/reopen |
Contributor
Author
|
/remove-lifecycle rotten |
openshift-ci
Bot
removed
the
lifecycle/rotten
Contributor
|
@vr4manta: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
|
@vr4manta: This pull request references SPLAT-2526 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "5.0." or "openshift-5.0.", but it targets "openshift-4.21" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
vr4manta
force-pushed
the
refactor-openshift-ext-2
branch
from
e46dfa6 to
5b8c498
Compare
openshift-ci
Bot
removed
the
needs-rebase
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
openshift-tests-extension/go.mod (1)
15-52: ⚡ Quick winRefactor dependency classification for idiomatic Go modules.
The main
requireblock mixes direct and indirect dependencies. Dependencies marked// indirect(lines 16-17, 21-23, 25, 28-35, 37, 39-51) should either be in a separaterequireblock or managed automatically bygo mod tidy. Mixing them with direct dependencies in a single block is non-idiomatic and makes it harder to distinguish actual direct dependencies from transitive ones.♻️ Suggested structure
Separate direct and indirect dependencies into distinct blocks:
require ( - github.com/go-logr/logr v1.4.2 // indirect - github.com/google/uuid v1.6.0 // indirect github.com/onsi/ginkgo/v2 v2.23.4 github.com/onsi/gomega v1.37.0 github.com/openshift-eng/openshift-tests-extension v0.0.0-20250711173707-dc2a20e5a5f8 - github.com/openshift/api v0.0.0-20251009093019-7837a801e8c1 // indirect - github.com/openshift/client-go v0.0.0-20250710075018-396b36f983ee // indirect - github.com/openshift/library-go v0.0.0-20250711143941-47604345e7ea // indirect github.com/openshift/machine-api-operator v0.0.0 - github.com/prometheus/client_golang v1.22.0 // indirect github.com/spf13/cobra v1.9.1 github.com/spf13/pflag v1.0.6 - github.com/stretchr/testify v1.10.0 // indirect - github.com/vmware/govmomi v0.46.3 // indirect - golang.org/x/net v0.38.0 // indirect - golang.org/x/time v0.10.0 // indirect - gopkg.in/gcfg.v1 v1.2.3 // indirect k8s.io/api v0.33.3 - k8s.io/apimachinery v0.33.3 // indirect - k8s.io/apiserver v0.33.3 // indirect k8s.io/client-go v0.33.3 - k8s.io/cloud-provider-vsphere v1.32.2 // indirect k8s.io/component-base v0.33.3 + k8s.io/kubernetes v1.33.3 +) + +require ( + github.com/go-logr/logr v1.4.2 // indirect + github.com/google/uuid v1.6.0 // indirect + github.com/openshift/api v0.0.0-20251009093019-7837a801e8c1 // indirect + github.com/openshift/client-go v0.0.0-20250710075018-396b36f983ee // indirect + github.com/openshift/library-go v0.0.0-20250711143941-47604345e7ea // indirect + github.com/prometheus/client_golang v1.22.0 // indirect + github.com/stretchr/testify v1.10.0 // indirect + github.com/vmware/govmomi v0.46.3 // indirect + golang.org/x/net v0.38.0 // indirect + golang.org/x/time v0.10.0 // indirect + gopkg.in/gcfg.v1 v1.2.3 // indirect + k8s.io/apimachinery v0.33.3 // indirect + k8s.io/apiserver v0.33.3 // indirect + k8s.io/cloud-provider-vsphere v1.32.2 // indirect k8s.io/cri-client v0.33.3 // indirect ... - k8s.io/kubernetes v1.33.3 - sigs.k8s.io/cluster-api v1.9.4 // indirect - sigs.k8s.io/controller-runtime v0.20.1 // indirect - sigs.k8s.io/yaml v1.4.0 // indirect )Alternatively, let
go mod tidyautomatically manage the indirect dependencies.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@openshift-tests-extension/go.mod` around lines 15 - 52, The go.mod require block mixes direct and transitive dependencies (lines showing entries like github.com/onsi/ginkgo/v2, github.com/onsi/gomega, github.com/openshift/... and many entries annotated with // indirect), which is non-idiomatic; fix by cleaning up the require block: run `go mod tidy` to let Go automatically prune and mark indirect dependencies, or manually separate true direct modules (e.g., github.com/onsi/ginkgo/v2, github.com/spf13/cobra, k8s.io/client-go, k8s.io/kubernetes) into a primary require block and move items with // indirect into a secondary require block so indirect entries are not mixed with direct ones, ensuring the comments (// indirect) accurately reflect transitive deps.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@hack/go-mod.sh`:
- Around line 11-14: The script runs cd ../openshift-tests-extension without
checking its result; update the cd invocation in hack/go-mod.sh to fail fast if
the directory change fails (e.g., use cd ../openshift-tests-extension || exit 1
or cd ../openshift-tests-extension || return) so the following go mod tidy / go
mod vendor / go mod verify commands do not run in the wrong directory; ensure
the chosen failure behavior matches the script's intended execution context
(exit for top-level script, return for sourced script).
In `@openshift-tests-extension/go.mod`:
- Line 135: The project currently pulls in github.com/opencontainers/runc v1.2.5
transitively; change the module requirement to at least v1.2.8 (or preferably
v1.4.2) by adding/updating an explicit require for
github.com/opencontainers/runc to the chosen version, then run go get
github.com/opencontainers/runc@v1.4.2 (or `@v1.2.8`) and go mod tidy to update
go.mod and go.sum; verify build/tests to ensure no breakage and that
github.com/opencontainers/runc no longer resolves to v1.2.5.
---
Nitpick comments:
In `@openshift-tests-extension/go.mod`:
- Around line 15-52: The go.mod require block mixes direct and transitive
dependencies (lines showing entries like github.com/onsi/ginkgo/v2,
github.com/onsi/gomega, github.com/openshift/... and many entries annotated with
// indirect), which is non-idiomatic; fix by cleaning up the require block: run
`go mod tidy` to let Go automatically prune and mark indirect dependencies, or
manually separate true direct modules (e.g., github.com/onsi/ginkgo/v2,
github.com/spf13/cobra, k8s.io/client-go, k8s.io/kubernetes) into a primary
require block and move items with // indirect into a secondary require block so
indirect entries are not mixed with direct ones, ensuring the comments (//
indirect) accurately reflect transitive deps.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: e82a0b88-672b-425d-b1cb-bf335e4b9951
⛔ Files ignored due to path filters (294)
openshift-tests-extension/go.sumis excluded by!**/*.sumopenshift-tests-extension/vendor/cel.dev/expr/.bazelversionis excluded by!**/vendor/**openshift-tests-extension/vendor/cel.dev/expr/.gitattributesis excluded by!**/vendor/**openshift-tests-extension/vendor/cel.dev/expr/.gitignoreis excluded by!**/vendor/**openshift-tests-extension/vendor/cel.dev/expr/BUILD.bazelis excluded by!**/vendor/**openshift-tests-extension/vendor/cel.dev/expr/CODE_OF_CONDUCT.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/cel.dev/expr/CONTRIBUTING.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/cel.dev/expr/GOVERNANCE.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/cel.dev/expr/LICENSEis excluded by!**/vendor/**openshift-tests-extension/vendor/cel.dev/expr/MAINTAINERS.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/cel.dev/expr/MODULE.bazelis excluded by!**/vendor/**openshift-tests-extension/vendor/cel.dev/expr/README.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/cel.dev/expr/WORKSPACEis excluded by!**/vendor/**openshift-tests-extension/vendor/cel.dev/expr/WORKSPACE.bzlmodis excluded by!**/vendor/**openshift-tests-extension/vendor/cel.dev/expr/checked.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/cel.dev/expr/cloudbuild.yamlis excluded by!**/vendor/**openshift-tests-extension/vendor/cel.dev/expr/eval.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/cel.dev/expr/explain.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/cel.dev/expr/regen_go_proto.shis excluded by!**/vendor/**openshift-tests-extension/vendor/cel.dev/expr/regen_go_proto_canonical_protos.shis excluded by!**/vendor/**openshift-tests-extension/vendor/cel.dev/expr/syntax.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/cel.dev/expr/value.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/LICENSEis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/README.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/SECURITY.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/constants.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/context.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/csi_entry_state.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/csi_param_state.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/escape_intermediate_state.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/escape_state.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/event_handler.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/ground_state.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/osc_string_state.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/parser.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/parser_action_helpers.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/parser_actions.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/states.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/utilities.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/winterm/ansi.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/winterm/api.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/winterm/attr_translation.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/winterm/cursor_helpers.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/winterm/erase_helpers.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/winterm/scroll_helper.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/winterm/utilities.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Azure/go-ansiterm/winterm/win_event_handler.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/JeffAshton/win_pdh/AUTHORSis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/JeffAshton/win_pdh/LICENSEis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/JeffAshton/win_pdh/README.mdownis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/JeffAshton/win_pdh/pdh.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/MakeNowJust/heredoc/LICENSEis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/MakeNowJust/heredoc/README.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/MakeNowJust/heredoc/heredoc.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/.gitattributesis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/.gitignoreis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/.golangci.ymlis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/CODEOWNERSis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/LICENSEis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/README.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/SECURITY.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/backup.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/doc.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/ea.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/file.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/fileinfo.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/hvsock.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/internal/fs/doc.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/internal/fs/fs.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/internal/fs/security.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/internal/fs/zsyscall_windows.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/internal/socket/rawaddr.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/internal/socket/socket.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/internal/socket/zsyscall_windows.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/internal/stringbuffer/wstring.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/pipe.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/pkg/guid/guid.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/pkg/guid/guid_nonwindows.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/pkg/guid/guid_windows.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/pkg/guid/variant_string.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/privilege.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/reparse.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/sd.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/syscall.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/go-winio/zsyscall_windows.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/.gitattributesis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/.gitignoreis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/CODEOWNERSis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/LICENSEis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/README.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/SECURITY.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/errors.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/hns_v1.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/hnsaccelnet.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/hnsglobals.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/hnssupport.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/internal/hns/doc.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/internal/hns/hns.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/internal/hns/hnsaccelnet.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/internal/hns/hnsendpoint.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/internal/hns/hnserrors.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/internal/hns/hnsfuncs.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/internal/hns/hnsglobals.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/internal/hns/hnsnetwork.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/internal/hns/hnspolicy.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/internal/hns/hnspolicylist.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/internal/hns/hnssupport.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/internal/hns/namespace.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/internal/hns/zsyscall_windows.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/internal/interop/doc.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/internal/interop/interop.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/Microsoft/hnslib/internal/interop/zsyscall_windows.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/NYTimes/gziphandler/.gitignoreis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/NYTimes/gziphandler/.travis.ymlis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/NYTimes/gziphandler/CODE_OF_CONDUCT.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/NYTimes/gziphandler/CONTRIBUTING.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/NYTimes/gziphandler/LICENSEis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/NYTimes/gziphandler/README.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/NYTimes/gziphandler/gzip.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/NYTimes/gziphandler/gzip_go18.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/.gitignoreis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/LICENSEis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/README.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/antlrdoc.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/atn.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/atn_config.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/atn_config_set.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/atn_deserialization_options.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/atn_deserializer.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/atn_simulator.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/atn_state.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/atn_type.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/char_stream.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/common_token_factory.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/common_token_stream.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/comparators.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/configuration.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/dfa.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/dfa_serializer.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/dfa_state.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/diagnostic_error_listener.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/error_listener.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/error_strategy.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/errors.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/file_stream.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/input_stream.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/int_stream.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/interval_set.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/jcollect.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/lexer.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/lexer_action.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/lexer_action_executor.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/lexer_atn_simulator.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/ll1_analyzer.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/nostatistics.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/parser.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/parser_atn_simulator.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/parser_rule_context.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/prediction_context.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/prediction_context_cache.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/prediction_mode.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/recognizer.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/rule_context.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/semantic_context.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/statistics.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/stats_data.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/token.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/token_source.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/token_stream.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/tokenstream_rewriter.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/trace_listener.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/transition.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/tree.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/trees.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/antlr4-go/antlr/v4/utils.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/armon/circbuf/.gitignoreis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/armon/circbuf/LICENSEis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/armon/circbuf/README.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/armon/circbuf/circbuf.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/beorn7/perks/LICENSEis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/beorn7/perks/quantile/exampledata.txtis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/beorn7/perks/quantile/stream.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/blang/semver/v4/LICENSEis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/blang/semver/v4/json.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/blang/semver/v4/range.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/blang/semver/v4/semver.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/blang/semver/v4/sort.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/blang/semver/v4/sql.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/cenkalti/backoff/v4/.gitignoreis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/cenkalti/backoff/v4/LICENSEis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/cenkalti/backoff/v4/README.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/cenkalti/backoff/v4/backoff.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/cenkalti/backoff/v4/context.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/cenkalti/backoff/v4/exponential.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/cenkalti/backoff/v4/retry.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/cenkalti/backoff/v4/ticker.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/cenkalti/backoff/v4/timer.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/cenkalti/backoff/v4/tries.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/cespare/xxhash/v2/LICENSE.txtis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/cespare/xxhash/v2/README.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/cespare/xxhash/v2/testall.shis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/cespare/xxhash/v2/xxhash.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/cespare/xxhash/v2/xxhash_amd64.sis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/cespare/xxhash/v2/xxhash_arm64.sis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/cespare/xxhash/v2/xxhash_asm.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/cespare/xxhash/v2/xxhash_other.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/cespare/xxhash/v2/xxhash_safe.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/cespare/xxhash/v2/xxhash_unsafe.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/.travis.ymlis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/LICENSEis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/README.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/doc.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/fs.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/fs_json.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/fs_os.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/fs_zip.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/gettext.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/locale.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/mo/doc.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/mo/encoder.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/mo/file.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/mo/header.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/mo/message.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/mo/util.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/plural/doc.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/plural/formula.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/plural/table.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/po/comment.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/po/doc.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/po/file.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/po/header.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/po/line_reader.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/po/message.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/po/re.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/po/util.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/tr.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/chai2010/gettext-go/util.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/container-storage-interface/spec/LICENSEis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/container-storage-interface/spec/lib/go/csi/csi.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/LICENSEis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/services/containers/v1/containers.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/services/containers/v1/containers.protois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/services/containers/v1/containers_grpc.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/services/containers/v1/containers_ttrpc.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/services/containers/v1/doc.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/services/tasks/v1/doc.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/services/tasks/v1/tasks.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/services/tasks/v1/tasks.protois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/services/tasks/v1/tasks_grpc.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/services/tasks/v1/tasks_ttrpc.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/services/version/v1/doc.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/services/version/v1/version.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/services/version/v1/version.protois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/services/version/v1/version_grpc.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/services/version/v1/version_ttrpc.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/types/descriptor.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/types/descriptor.protois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/types/doc.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/types/event.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/types/event.protois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/types/fieldpath.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/types/fieldpath.protois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/types/introspection.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/types/introspection.protois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/types/metrics.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/types/metrics.protois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/types/mount.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/types/mount.protois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/types/platform.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/types/platform.protois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/types/platform_helpers.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/types/sandbox.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/types/sandbox.protois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/types/task/doc.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/types/task/task.pb.gois excluded by!**/*.pb.go,!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/containerd/api/types/task/task.protois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/errdefs/LICENSEis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/errdefs/README.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/errdefs/errors.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/errdefs/pkg/LICENSEis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/errdefs/pkg/errgrpc/grpc.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/errdefs/pkg/internal/cause/cause.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/errdefs/pkg/internal/types/collapsible.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/errdefs/resolve.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/log/.golangci.ymlis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/log/LICENSEis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/log/README.mdis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/log/context.gois excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/ttrpc/.gitattributesis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/ttrpc/.gitignoreis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/ttrpc/.golangci.ymlis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/ttrpc/LICENSEis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/ttrpc/Makefileis excluded by!**/vendor/**openshift-tests-extension/vendor/github.com/containerd/ttrpc/PROTOCOL.mdis excluded by!**/vendor/**
📒 Files selected for processing (6)
Makefilehack/go-mod.shopenshift-tests-extension/cmd/main.goopenshift-tests-extension/cmd/provider.goopenshift-tests-extension/cmd/types.goopenshift-tests-extension/go.mod
💤 Files with no reviewable changes (1)
- openshift-tests-extension/cmd/provider.go
vr4manta
force-pushed
the
refactor-openshift-ext-2
branch
from
b497c36 to
d46b8c0
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@hack/go-mod.sh`:
- Line 3: Replace the lone "set -e" with a stricter shell option to ensure
pipeline failures and unset variables don't get masked—use "set -euo pipefail"
(or at minimum "set -e -o pipefail") at the top of hack/go-mod.sh so failures
from commands like "go work edit -json" propagate and the MODULES discovery
won't silently produce an empty value.
In `@openshift-tests-extension/go.mod`:
- Line 119: Update the vulnerable module github.com/moby/spdystream from v0.5.0
to v0.5.1 in go.mod by replacing the existing require entry
(github.com/moby/spdystream v0.5.0) with v0.5.1 or add an explicit
require/replace for github.com/moby/spdystream v0.5.1; then run go mod tidy to
refresh go.sum so the new version is pinned and the CVE (CVE-2026-35469) is
mitigated.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 9c895212-1534-4196-b73f-5ed9dbcea27a
⛔ Files ignored due to path filters (4)
go.sumis excluded by!**/*.sumgo.workis excluded by!**/*.workgo.work.sumis excluded by!**/*.sumopenshift-tests-extension/go.sumis excluded by!**/*.sum
📒 Files selected for processing (11)
go.modhack/go-mod.shopenshift-tests-extension/cmd/main.goopenshift-tests-extension/go.modopenshift-tests-extension/test/e2e/nutanix/multi-subnet.goopenshift-tests-extension/test/e2e/nutanix/util.goopenshift-tests-extension/test/e2e/util.goopenshift-tests-extension/test/e2e/vsphere/hostzonal.goopenshift-tests-extension/test/e2e/vsphere/machines.goopenshift-tests-extension/test/e2e/vsphere/multi-nic.goopenshift-tests-extension/test/e2e/vsphere/util.go
✅ Files skipped from review due to trivial changes (1)
- openshift-tests-extension/test/e2e/vsphere/multi-nic.go
vr4manta
force-pushed
the
refactor-openshift-ext-2
branch
from
d46b8c0 to
61b3f48
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (1)
openshift-tests-extension/go.mod (1)
119-119:⚠️ Potential issue | 🟠 Major | ⚡ Quick winUpgrade
github.com/moby/spdystreamfrom v0.5.0 to v0.5.1 to address CVE-2026-35469 (GHSA-pc3f-x583-g7j2).The current version contains a HIGH severity DoS vulnerability in the SPDY/3 frame parser. Version v0.5.1 includes the fix.
🔒 Proposed fix
Add an explicit replace directive to pin the patched version:
// Mandatory: replace ( github.com/onsi/ginkgo/v2 => github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20260303184444-1cc650aa0565 + github.com/moby/spdystream => github.com/moby/spdystream v0.5.1 k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.35.0Then run:
go mod tidy🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@openshift-tests-extension/go.mod` at line 119, Update the dependency for github.com/moby/spdystream to the patched v0.5.1: edit go.mod to either change the require entry for github.com/moby/spdystream from v0.5.0 to v0.5.1 or add an explicit replace directive pinning github.com/moby/spdystream => github.com/moby/spdystream v0.5.1, then run go mod tidy (and re-vendor if your repo vendors modules) to ensure the resolved build uses v0.5.1 to address CVE-2026-35469.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@openshift-tests-extension/go.mod`:
- Line 119: Update the dependency for github.com/moby/spdystream to the patched
v0.5.1: edit go.mod to either change the require entry for
github.com/moby/spdystream from v0.5.0 to v0.5.1 or add an explicit replace
directive pinning github.com/moby/spdystream => github.com/moby/spdystream
v0.5.1, then run go mod tidy (and re-vendor if your repo vendors modules) to
ensure the resolved build uses v0.5.1 to address CVE-2026-35469.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 0cfa2e63-e54a-412d-bae2-a2a52a4fa4cd
⛔ Files ignored due to path filters (4)
go.sumis excluded by!**/*.sumgo.workis excluded by!**/*.workgo.work.sumis excluded by!**/*.sumopenshift-tests-extension/go.sumis excluded by!**/*.sum
📒 Files selected for processing (14)
Makefilego.modhack/go-mod.shopenshift-tests-extension/cmd/main.goopenshift-tests-extension/cmd/provider.goopenshift-tests-extension/cmd/types.goopenshift-tests-extension/go.modopenshift-tests-extension/test/e2e/nutanix/multi-subnet.goopenshift-tests-extension/test/e2e/nutanix/util.goopenshift-tests-extension/test/e2e/util.goopenshift-tests-extension/test/e2e/vsphere/hostzonal.goopenshift-tests-extension/test/e2e/vsphere/machines.goopenshift-tests-extension/test/e2e/vsphere/multi-nic.goopenshift-tests-extension/test/e2e/vsphere/util.go
💤 Files with no reviewable changes (1)
- openshift-tests-extension/cmd/provider.go
✅ Files skipped from review due to trivial changes (2)
- openshift-tests-extension/test/e2e/nutanix/multi-subnet.go
- openshift-tests-extension/test/e2e/vsphere/util.go
🚧 Files skipped from review as they are similar to previous changes (6)
- Makefile
- openshift-tests-extension/test/e2e/vsphere/multi-nic.go
- openshift-tests-extension/cmd/main.go
- hack/go-mod.sh
- openshift-tests-extension/test/e2e/vsphere/machines.go
- go.mod
vr4manta
force-pushed
the
refactor-openshift-ext-2
branch
from
61b3f48 to
893657a
Compare
Contributor
Author
|
/test all |
Contributor
|
@vr4manta: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
vr4manta
force-pushed
the
refactor-openshift-ext-2
branch
from
893657a to
50e6088
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
openshift-tests-extension/cmd/main.go (1)
49-71:⚠️ Potential issue | 🟠 MajorUpdate all test suites to use the new kubeconfig helper pattern instead of
e2e.LoadConfig().The following test files still call
e2e.LoadConfig()in their setup, which depends on the old framework bootstrap that has been removed:
openshift-tests-extension/test/e2e/vsphere/multi-nic.go:172openshift-tests-extension/test/e2e/vsphere/hostzonal.go:47openshift-tests-extension/test/e2e/vsphere/machines.go:40openshift-tests-extension/test/e2e/nutanix/multi-subnet.go:285These tests will fail at runtime when the registered specs execute. Migrate them to use
NewClientConfigForTest()from the util package.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@openshift-tests-extension/cmd/main.go` around lines 49 - 71, The tests still call the removed e2e.LoadConfig() bootstrap helper; update each affected suite (e.g., the setups in test files listed) to use the new kubeconfig helper pattern by calling util.NewClientConfigForTest() instead of e2e.LoadConfig(), adjust imports to pull the util package, and propagate the returned rest.Config/ClientConfig to any code that previously consumed e2e.LoadConfig(); locate the test setup functions referenced by the registered specs produced by BuildExtensionTestSpecsFromOpenShiftGinkgoSuite() and ensure the new client config is used before those specs are added (kubeTestsExtension.AddSpecs).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@openshift-tests-extension/test/e2e/util.go`:
- Around line 27-28: The code currently forces api.Config/RESTTLS settings to
set InsecureSkipTLSVerify=true for every test client; remove that unconditional
assignment and instead load the cluster config using clientcmd (e.g.,
clientcmd.BuildConfigFromFlags or clientcmd.ClientConfig) and respect the TLS
settings present in the kubeconfig/rest.Config so InsecureSkipTLSVerify remains
false by default; if an override is needed for local debugging, add an explicit
flag or env var (e.g., TEST_SKIP_TLS_VERIFY) that, when set, toggles
InsecureSkipTLSVerify on the constructed rest.Config, and ensure the code paths
that reference InsecureSkipTLSVerify, clientcmd, and api.Config/rest.Config are
updated accordingly.
---
Outside diff comments:
In `@openshift-tests-extension/cmd/main.go`:
- Around line 49-71: The tests still call the removed e2e.LoadConfig() bootstrap
helper; update each affected suite (e.g., the setups in test files listed) to
use the new kubeconfig helper pattern by calling util.NewClientConfigForTest()
instead of e2e.LoadConfig(), adjust imports to pull the util package, and
propagate the returned rest.Config/ClientConfig to any code that previously
consumed e2e.LoadConfig(); locate the test setup functions referenced by the
registered specs produced by BuildExtensionTestSpecsFromOpenShiftGinkgoSuite()
and ensure the new client config is used before those specs are added
(kubeTestsExtension.AddSpecs).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 13b70d3c-060f-4ce5-8f6b-562a4441e9e9
⛔ Files ignored due to path filters (4)
go.sumis excluded by!**/*.sumgo.workis excluded by!**/*.workgo.work.sumis excluded by!**/*.sumopenshift-tests-extension/go.sumis excluded by!**/*.sum
📒 Files selected for processing (14)
Makefilecmd/machine-api-tests-ext/provider.gocmd/machine-api-tests-ext/types.gogo.modhack/go-mod.shopenshift-tests-extension/cmd/main.goopenshift-tests-extension/go.modopenshift-tests-extension/test/e2e/nutanix/multi-subnet.goopenshift-tests-extension/test/e2e/nutanix/util.goopenshift-tests-extension/test/e2e/util.goopenshift-tests-extension/test/e2e/vsphere/hostzonal.goopenshift-tests-extension/test/e2e/vsphere/machines.goopenshift-tests-extension/test/e2e/vsphere/multi-nic.goopenshift-tests-extension/test/e2e/vsphere/util.go
💤 Files with no reviewable changes (2)
- cmd/machine-api-tests-ext/types.go
- cmd/machine-api-tests-ext/provider.go
✅ Files skipped from review due to trivial changes (3)
- openshift-tests-extension/test/e2e/nutanix/multi-subnet.go
- openshift-tests-extension/test/e2e/vsphere/multi-nic.go
- openshift-tests-extension/test/e2e/vsphere/util.go
🚧 Files skipped from review as they are similar to previous changes (5)
- openshift-tests-extension/test/e2e/vsphere/machines.go
- Makefile
- hack/go-mod.sh
- openshift-tests-extension/go.mod
- go.mod
vr4manta
force-pushed
the
refactor-openshift-ext-2
branch
from
50e6088 to
f47778c
Compare
Contributor
Author
|
/test all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPLAT-2526
Changes
Notes
Previous PR seems to have caused an issue w/ core origin tests resulting in failures. Most seem to exhibit context deadline exceeded. This PR is an attempt to fix those after the revert.
Summary by CodeRabbit