Add S1185 recipe: Remove methods that only call super#837
Merged
Conversation
Implements RSPEC-S1185 to detect and remove methods that override a parent method but only delegate to super with the same arguments. Includes 12 comprehensive test cases covering positive and negative scenarios.
Consolidate triple-pass (count params, count args, match) into a single pass that counts and matches simultaneously.
Final overrides intentionally prevent further subclass overriding, so they should not be removed even if they only call super.
A @deprecated method that merely delegates to super is doubly redundant and should be removed along with plain @Override-only methods.
Remove removeMethodWithOnlyOverrideAnnotation which duplicated existing coverage. Add test verifying methods with semantic annotations like @transactional are retained.
steve-aom-elliott
approved these changes
Apr 15, 2026
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements RSPEC-S1185 to detect and remove methods that override a parent method but only delegate to super with the same arguments. Methods are safe to remove only if they have no semantic annotations, no Javadoc, and don't widen visibility.
Includes 12 comprehensive test cases covering positive and negative scenarios.