Test PR | Don't Merge | Drop the addition of XModuleMixin for the xblocks-contrib blocks#38250
Closed
Test PR | Don't Merge | Drop the addition of XModuleMixin for the xblocks-contrib blocks#38250
Conversation
farhan
force-pushed
the
farhan/drop-legacy-mixins-for-xblocks-contrib
branch
from
dd46720 to
12b0f9d
Compare
farhan
changed the title
farhan
force-pushed
the
farhan/drop-legacy-mixins-for-xblocks-contrib
branch
from
12b0f9d to
ec6b9a2
Compare
farhan
force-pushed
the
farhan/drop-legacy-mixins-for-xblocks-contrib
branch
from
ec6b9a2 to
95f6ef1
Compare
farhan
changed the title
Contributor
Author
|
So closing this PR on account of this PR openedx/XBlock#903 which is working for the required testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: openedx/xblocks-contrib#223
In this PR I tried to avoid the addition of XModuleMixin to xblocks-contrib blocks but it couldn't happen because of complexity of the code and its dependency on the xblock/runtime.py:Mixologist class
So closing this PR on account of this PR openedx/XBlock#903 which is working for the required testing
Finding:
component.py, preview.py and split.pychanges are impacting only at runtime reading from the logs (while rendering the blocks on lms/cms)