feat: roles and permissions button redirect added#2975
Conversation
|
Thanks for the pull request, @jesusbalderramawgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| }, | ||
| addRolesPermissionsBtnText: { | ||
| id: 'course-authoring.studio-home.add-roles-permissions.btn.text', | ||
| defaultMessage: 'Roles and permissions', |
There was a problem hiding this comment.
Add a description to this message.
jacobo-dominguez-wgu
left a comment
There was a problem hiding this comment.
Looks good, just add some unit tests to support your modifications and prevent regressions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2975 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 1383 1383
Lines 32642 32645 +3
Branches 7498 7498
=======================================
+ Hits 31165 31168 +3
Misses 1408 1408
Partials 69 69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thank you I have updated the PR with your suggestions |
jacobo-dominguez-wgu
left a comment
There was a problem hiding this comment.
Works as expected, LGTM!
@jesusbalderramawgu please rebase and solve conflicts!
done @jacobo-dominguez-wgu I've updated the PR! |
Description
Roles and permission button added to settings menu and authoring home to make the redirection to admin console
this closes this task
Screenshots
admin console redirection