feat: Info Sidebar menus [FC-0123] by ChrisChV · Pull Request #2937 · openedx/frontend-app-authoring

ChrisChV · 2026-03-10T22:03:54Z

Description

Add menus in the info sidebar for:
- Section
- Subsection
- Unit in the course outline
- Unit in the unit page
- Components in the unit page
Which user roles will this change impact? "Course Author".

Supporting information

Github issue: Sidebar Overflow Menus #2790
Internal ticket: FAL-4337

Testing instructions

In the course outline, create a Section > Subsection > Unit > Some components.
In the course outline, add a Section, Subsection, Unit, and some components from a content library.
In the course outline, click in the Section Card to open the Section Info Sidebar.
Test the Menus: Duplicate, Move Up, Move Down, Delete.
In the Section from the library test the menus: View in Library, Unlink from library.
In the course outline, click in the Subsection Card to open the Subsection Info Sidebar.
Test the Menus: Duplicate, Move Up, Move Down, Delete.
In the Subsection from the library test the menus: View in Library, Unlink from library.
In the course outline, click in the Unit Card to open the Unit Info Sidebar.
Test the Menus: Duplicate, Copy to Clipboard, Copy Location Id, Move Up, Move Down, Delete.
In the Unit from the library test the menus: View in Library, Unlink from library.
In the unit page, test the Menus in the unit sidebar info: Copy to Clipboard, Copy Location id, Delete.
Open the unit page for the unit from library, test the menus: View in Library, Unlink from library
Click in a component to open the component sidebar, test the menus: Duplicate, Copy to Clipboard, Move, Delete.
Click in a component from library, test the menus: View in Library, Unlink from library.

Other information

N/A

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

Any new files are using TypeScript (.ts, .tsx).
Avoid propTypes and defaultProps in any new or modified code.
Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
All new i18n messages in messages.ts files have a description for translators to use.
Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

openedx-webhooks · 2026-03-10T22:04:00Z

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2026-03-12T22:11:38Z

Codecov Report

❌ Patch coverage is 96.55172% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.59%. Comparing base (806135e) to head (13f3b2f).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
src/course-outline/CourseOutlineContext.tsx	95.74%	4 Missing ⚠️
...it/unit-sidebar/unit-info/ComponentInfoSidebar.tsx	95.38%	3 Missing ⚠️
...se-unit/unit-sidebar/unit-info/UnitInfoSidebar.tsx	94.33%	3 Missing ⚠️
src/library-authoring/history-log/HistoryLog.tsx	0.00%	3 Missing ⚠️
...e/outline-sidebar/info-sidebar/UnitInfoSidebar.tsx	96.82%	2 Missing ⚠️
src/course-unit/xblock-container-iframe/index.tsx	91.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2937      +/-   ##
==========================================
+ Coverage   95.57%   95.59%   +0.01%     
==========================================
  Files        1375     1379       +4     
  Lines       31954    32278     +324     
  Branches     7280     7405     +125     
==========================================
+ Hits        30540    30856     +316     
- Misses       1350     1358       +8     
  Partials       64       64

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

navinkarkera

@ChrisChV Left some comments.

The menu options in the sidebar are not considering library links while showing duplicate, move, delete etc. options. Author should not be able to perform these actions if the parent item is linked to a library. You can refer to components menu items to determine the disabled options.

We have same issue in component sidebar menu in unit page as well.

navinkarkera · 2026-03-30T08:31:50Z

+  useEffect(() => {
+    dispatch(fetchCourseOutlineIndexQuery(courseId));
+  }, [courseId]);


Is this required? We have the same in hooks.jsx

Yes, it makes more sense to put it there, since that's where the sections are being saved. I've removed the duplicate.

navinkarkera · 2026-03-30T08:44:04Z

+  const sectionIndex = selectedContainerState?.sectionIndex;
+  const section = sectionIndex !== undefined ? sections[sectionIndex] : undefined;
+  const subsectionIndex = section && selectedContainerState?.subsectionId
+    ? section.childInfo.children.findIndex((s) => s.id === selectedContainerState.subsectionId)
+    : -1;
+  const subsection = subsectionIndex !== -1 ? section?.childInfo.children[subsectionIndex] : undefined;


Do we need to store sectionIndex in the selectedContainerState context? Like you are getting subsectionIndex, you can also fetch sectionIndex and unitIndex no?

Also, I would just use useCourseItemData to get element data instead of using index.

For example, line 78 can be replaced with

const { data: section } = useCourseItemData(selectedContainerState?.sectionId);

This will be helpful while replacing redux with react query and the data will be up to date.

Updated: 5b3a68e

ChrisChV · 2026-04-03T00:06:47Z

The menu options in the sidebar are not considering library links while showing duplicate, move, delete etc. options. Author should not be able to perform these actions if the parent item is linked to a library. You can refer to components menu items to determine the disabled options.

Thanks! Updated in a2583bc

navinkarkera

@ChrisChV Thanks! Looks good.

👍

I tested this: (Verified menu items in sidebar)
I read through the code
I checked for accessibility issues
Includes documentation

bradenmacdonald · 2026-04-06T22:32:42Z

+      // Fallback for HTTP (non-secure) dev environments
+      // Note: execCommand is deprecated but still widely supported as fallback
+      const textarea = document.createElement('textarea');
+      textarea.value = locationId;
+      document.body.appendChild(textarea);
+      textarea.select();
+      document.execCommand('copy'); // eslint-disable-line deprecation/deprecation
+      document.body.removeChild(textarea);


Oh nice. We should put this on the Files & Uploads page sometime too: #2463

bradenmacdonald · 2026-04-06T22:58:59Z

+  sections: XBlock[];
+  restoreSectionList: () => void;
+  setSections: React.Dispatch<React.SetStateAction<XBlock[]>>;
+  isDuplicatingItem: boolean;
+  isDeleteModalOpen: boolean;
+  openDeleteModal: () => void;
+  closeDeleteModal: () => void;
+  getHandleDeleteItemSubmit: (callback: () => void) => () => Promise<void>;
+  handleDuplicateSectionSubmit: () => void;
+  handleDuplicateSubsectionSubmit: () => void;
+  handleDuplicateUnitSubmit: () => void;
+  handleSectionDragAndDrop: (sectionListIds: string[]) => void;
+  handleSubsectionDragAndDrop: (sectionId: string, prevSectionId: string, subsectionListIds: string[]) => void;
+  handleUnitDragAndDrop: (sectionId: string, prevSectionId: string, subsectionId: string, unitListIds: string[]) => void;
+  updateSectionOrderByIndex: (currentIndex: number, newIndex: number) => void;
+  updateSubsectionOrderByIndex: (section: XBlock, moveDetails: any) => void;
+  updateUnitOrderByIndex: (section: XBlock, moveDetails: any) => void;


This context is getting very big, and many of these new additions do not seem relevant to most course pages like advanced settings, files & uploads, unit content, sync updates, etc.

What do you think about moving some of these to a separate CourseOutlineContext that's only for the course outline page?

Done. I refactored the code in 5b332b2

… CourseAuthoringContext.tsx

ChrisChV · 2026-04-07T20:39:53Z

@bradenmacdonald It's ready for another review. @navinkarkera, I made a refactor in the code, so it needs another round of UI testing

bradenmacdonald · 2026-04-11T18:07:46Z

@ChrisChV Thanks for those refactors! And sorry for the reviewing delay here.

While testing, I noticed a weird bug. But I think you can fix it after the merge, as it's not a big deal.
When I "move down" a subsection, one of the units that I duplicated earlier in the other subsection gets highlighted for a couple seconds as if it is newly created.

Weird.bug.mov

bradenmacdonald

LGTM! I noticed some minor things when testing which I mentioned on #2790 as well as the comment above ^. But they don't need to block the merge.

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 10, 2026

ChrisChV marked this pull request as draft March 10, 2026 22:04

openedx-webhooks added this to Contributions Mar 10, 2026

github-project-automation Bot moved this to Needs Triage in Contributions Mar 10, 2026

mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Mar 11, 2026

ChrisChV changed the title ~~feat: Sidebar menus~~ feat: Info Sidebar menus Mar 12, 2026

ChrisChV marked this pull request as ready for review March 12, 2026 22:12

ChrisChV changed the title ~~feat: Info Sidebar menus~~ feat: Info Sidebar menus [FC-123] Mar 12, 2026

ChrisChV changed the title ~~feat: Info Sidebar menus [FC-123]~~ feat: Info Sidebar menus [FC-0123] Mar 12, 2026

ChrisChV added 8 commits March 16, 2026 13:51

feat: Initial work for menus in sidebard

a39678b

feat: Enable Move menus in subsections

db4e71a

feat: Enable move in unit sidebar

0fd1d2e

feat: Enable Delete in all container info sidebars

71816a2

feat: Enable Unlik from library in container sidebars

7cea73d

feat: Enable view library menu in all container sidebars

adb5295

feat: Enable copy menus in unit info sidebar

df90eec

feat: Enable menus in unit info sidebar in the unit page

69f03ca

ChrisChV force-pushed the chris/FAL-4337-sidebar-menus branch from 7d68b07 to a143306 Compare March 16, 2026 18:51

feat: Enable menus in component info sideber in unit page

3e4bcac

ChrisChV force-pushed the chris/FAL-4337-sidebar-menus branch from a143306 to 3e4bcac Compare March 16, 2026 23:01

fix: Broken coverage

685fd31

navinkarkera suggested changes Mar 30, 2026

View reviewed changes

ChrisChV added 3 commits April 2, 2026 17:17

refactor: Avoid use sectionIndex in selectedContainerState

5b3a68e

fix: Hide some menu actions if the parent is from a library

a2583bc

Merge branch 'master' into chris/FAL-4337-sidebar-menus

a9f343a

ChrisChV requested a review from navinkarkera April 3, 2026 00:06

navinkarkera approved these changes Apr 3, 2026

View reviewed changes

fix: Broken tests

5ba4882

mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Apr 6, 2026

mphilbrick211 moved this from Waiting on Author to In Eng Review in Contributions Apr 6, 2026

ChrisChV requested a review from bradenmacdonald April 6, 2026 22:13

bradenmacdonald mentioned this pull request Apr 6, 2026

Improve copying asset URLs in devstack deployments #2463

Open

bradenmacdonald reviewed Apr 6, 2026

View reviewed changes

ChrisChV added 3 commits April 7, 2026 14:35

refactor: Created CourseOutlineContext.tsx and move some content from…

5b332b2

… CourseAuthoringContext.tsx

Merge branch 'master' into chris/FAL-4337-sidebar-menus

f45f876

fix: Broken tests

6556dcb

ChrisChV requested review from bradenmacdonald and navinkarkera April 7, 2026 20:39

bradenmacdonald approved these changes Apr 11, 2026

View reviewed changes

Merge branch 'master' into chris/FAL-4337-sidebar-menus

13f3b2f

ChrisChV merged commit 199823a into openedx:master Apr 13, 2026
7 checks passed

github-project-automation Bot moved this from In Eng Review to Done in Contributions Apr 13, 2026

ChrisChV deleted the chris/FAL-4337-sidebar-menus branch April 13, 2026 16:28

Conversation

ChrisChV commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Supporting information

Testing instructions

Other information

Best Practices Checklist

Uh oh!

openedx-webhooks commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

navinkarkera left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

navinkarkera Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

ChrisChV Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

navinkarkera Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

ChrisChV Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

ChrisChV commented Apr 3, 2026

Uh oh!

navinkarkera left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bradenmacdonald Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bradenmacdonald Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

ChrisChV Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ChrisChV commented Apr 7, 2026

Uh oh!

bradenmacdonald commented Apr 11, 2026

Uh oh!

bradenmacdonald left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ChrisChV commented Mar 10, 2026 •

edited

Loading

openedx-webhooks commented Mar 10, 2026 •

edited

Loading

codecov Bot commented Mar 12, 2026 •

edited

Loading

navinkarkera left a comment •

edited

Loading