fix: Fix thread api call to work with teams#269
Open
saraburns1 wants to merge 3 commits intomasterfrom
Open
Conversation
forum/api/threads.py
Outdated
| "user_id": user_id, | ||
| "group_id": group_id, | ||
| "group_ids": group_ids, | ||
| "context": kwargs.get("context", None), |
There was a problem hiding this comment.
Everything else in here is using an explicit param instead of kwargs, would updating get_user_threads to have an explicit context param make more sense?
brian-smith-tcril
approved these changes
Mar 30, 2026
brian-smith-tcril
left a comment
brian-smith-tcril
left a comment
There was a problem hiding this comment.
LGTM! Would probably be good to get someone with more python expertise to take a quick look though.
Contributor
|
@saraburns1 changes look good, can we add a unit test for this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was found during investigation into openedx/openedx-platform#36841
Current functionality - Team posts do not show up at all, even right after creating. Discussion posts are fine.
Screen.Recording.2026-03-26.at.1.16.07.PM.mov
New functionality - Team posts are there (due to sending correct 'context' value to api). Discussion posts remain unchanged.
context is set to 'standalone' here for Teams threads, but the default context in the api when finding threads to display was 'course' which is why nothing was being returned.
Screen.Recording.2026-03-26.at.1.17.47.PM.mov