-
Notifications
You must be signed in to change notification settings - Fork 36
device-identity-provisioning: add keypair discovery and rename to Att… #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fdamato
wants to merge
1
commit into
opencomputeproject:main
Choose a base branch
from
fdamato:fadamato/device_identity_prov_attested_csr_discovery
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
67 changes: 67 additions & 0 deletions
67
specifications/device-identity-provisioning/cddl/attested-csr-eat.cddl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| ; An Attested CSR EAT is one of two variants: | ||
| ; - A CSR response, returned for a specific KeyPairID > 0. | ||
| ; - A keypair-inventory (discovery) response, returned when the | ||
| ; Requester specifies KeyPairID = 0. | ||
| cwt-attested-csr-eat = | ||
| cwt-attested-csr-eat-csr / | ||
| cwt-attested-csr-eat-inventory | ||
|
|
||
| cwt-attested-csr-eat-csr = { | ||
| ; Issuer claim is StringOrURI (tstr) | ||
| &(iss : 1) => tstr | ||
|
|
||
| ; Nonce claim is nonce-type = bstr .size (8..64) | ||
| ? &(nonce : 10) => bstr | ||
|
|
||
| ; Private Claims (they have to be < -65536 for rfc8392) | ||
|
|
||
| ; CSR bytestring | ||
| &(csr: -70001) => bstr | ||
|
|
||
| ; Attribute List of OIDs | ||
| &(attrib: -70002) => [+ $key-attributes-type] | ||
| } | ||
|
|
||
| ; Discovery response payload returned when KeyPairID = 0 in the request. | ||
| cwt-attested-csr-eat-inventory = { | ||
| &(iss : 1) => tstr | ||
|
|
||
| ? &(nonce : 10) => bstr | ||
|
|
||
| ; KeyPair Inventory private claim. Each entry pairs a KeyPairID | ||
| ; with the list of derivation-attribute OIDs that apply to it. | ||
| &(keypair-inventory: -70003) => [+ keypair-inventory-entry] | ||
| } | ||
|
|
||
| keypair-inventory-entry = [ | ||
| keypair-id: 1..255, | ||
| attributes: [+ $key-attributes-type] | ||
| ] | ||
|
|
||
| $key-attributes-type = tagged-oid-type | ||
|
|
||
| signed-cwt = #6.18(COSE-Sign1-attested-csr) | ||
|
|
||
| COSE-Sign1-attested-csr = [ | ||
| protected: bstr .cbor protected-esc-header-map | ||
| unprotected: unprotected-esc-header-map | ||
| payload: bstr .cbor cwt-attested-csr-eat | ||
| signature: bstr | ||
| ] | ||
|
|
||
| protected-esc-header-map { | ||
| ; Well-defined header fields | ||
| &(alg-id: 1) => int | ||
| &(content-type: 3) => tstr / int | ||
| &(issuer-key-id: 4) => bstr | ||
| ; User-defined fields | ||
| * cose-label => cose-value | ||
| } | ||
|
|
||
| unprotected-esc-header-map = { | ||
| ; The Attestation Key's certificate chain is NOT carried here; the | ||
| ; Requester retrieves it via SPDM GET_CERTIFICATE for the slot | ||
| ; identified by SignerSlotIDParam. | ||
| * cose-label => cose-value | ||
| } | ||
|
|
44 changes: 0 additions & 44 deletions
44
specifications/device-identity-provisioning/cddl/envelope-signed-csr-eat.cddl
This file was deleted.
Oops, something went wrong.
61 changes: 61 additions & 0 deletions
61
specifications/device-identity-provisioning/diag/attested-csr-eat-example.diag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| ; ---------------------------------------------------------------------- | ||
| ; Example: CSR response (returned when the Requester sent | ||
| ; GET_ATTESTED_CSR with a specific KeyPairID > 0). The payload | ||
| ; carries the CSR for the selected keypair along with the derivation- | ||
| ; attribute OIDs that apply to it. | ||
| ; ---------------------------------------------------------------------- | ||
|
|
||
| signed-cwt / 18([ | ||
| / protected / <<{ | ||
| / alg-id / 1 : 7, | ||
| / content-type / 3 : "application/eat+cbor", | ||
| ; SHA-384 digest of the Attestation Key (i.e. the SPDM Signing Key) | ||
| ; that produced this envelope signature. | ||
| / kid / 4 : h'1a2b3c4d5e6f70819203a4b5c6d7e8f900112233445566778899aabbccddeeff00112233445566778899aabbccddeeff' | ||
| }>>, | ||
| / unprotected / {}, | ||
| / payload / <<{ | ||
| / iss / 1 : "RT Alias Key", | ||
| / nonce / 10: h'AAAABBBBAAAABBBBAAAABBBB', | ||
| / csr / -70001 : h'59025630820252308201d9a003020102021431a4e0', | ||
| / attrib / -70002: [ | ||
| / tagged-oid-type / 111(h'6086480186F84D010F046301') | ||
| ] | ||
| }>>, | ||
| / signature / h'FA45AAB345AB4988' | ||
| ]) | ||
|
|
||
| ; ---------------------------------------------------------------------- | ||
| ; Example: discovery response (returned when the Requester sent | ||
| ; GET_ATTESTED_CSR with KeyPairID = 0). The payload omits the | ||
| ; CSR/attrib claims and instead carries the KeyPair Inventory claim, | ||
| ; which enumerates every supported KeyPairID and its derivation OIDs. | ||
| ; ---------------------------------------------------------------------- | ||
|
|
||
| signed-cwt / 18([ | ||
| / protected / <<{ | ||
| / alg-id / 1 : 7, | ||
| / content-type / 3 : "application/eat+cbor", | ||
| ; SHA-384 digest of the Attestation Key (i.e. the SPDM Signing Key) | ||
| ; that produced this envelope signature. | ||
| / kid / 4 : h'1a2b3c4d5e6f70819203a4b5c6d7e8f900112233445566778899aabbccddeeff00112233445566778899aabbccddeeff' | ||
| }>>, | ||
| / unprotected / {}, | ||
| / payload / <<{ | ||
| / iss / 1 : "RT Alias Key", | ||
| / nonce / 10 : h'AAAABBBBAAAABBBBAAAABBBB', | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Change to 32 bytes same as SPDM nonce |
||
| / keypair-inventory / -70003 : [ | ||
| ; KeyPairID 1: IDevID, derived from First Mutable Code | ||
| [ 1, [ 111(h'6086480186F84D010F040602') ] ], | ||
| ; KeyPairID 2: LDevID, derived from Owner Entropy Fuse + | ||
| ; First Mutable Code | ||
| [ 2, [ | ||
| 111(h'6086480186F84D010F040601'), | ||
| 111(h'6086480186F84D010F040602') | ||
| ] ], | ||
| ; KeyPairID 3: Owner-provisioned alias key | ||
| [ 3, [ 111(h'6086480186F84D010F040604') ] ] | ||
| ] | ||
| }>>, | ||
| / signature / h'FA45AAB345AB4988' | ||
| ]) | ||
18 changes: 0 additions & 18 deletions
18
specifications/device-identity-provisioning/diag/envelope-signed-csr-eat-example.diag
This file was deleted.
Oops, something went wrong.
File renamed without changes
File renamed without changes
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to hash of cert chain (same as DIGEST response)