Skip to content

fix(scheduler): ignore unset SIGCHLD signals#14047

Merged
anmonteiro merged 1 commit intoocaml:mainfrom
anmonteiro:anmonteiro/ignore-unset-sigchld-signals
Apr 5, 2026
Merged

fix(scheduler): ignore unset SIGCHLD signals#14047
anmonteiro merged 1 commit intoocaml:mainfrom
anmonteiro:anmonteiro/ignore-unset-sigchld-signals

Conversation

@anmonteiro
Copy link
Copy Markdown
Collaborator

alternative to #14023

Copy link
Copy Markdown
Member

@rgrinberg rgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This improves the behavior, though I'm wondering if this is just a band-aid. Dune needs to handle signals in a reliable on macos.

Comment thread src/dune_scheduler/signal_watcher.ml Outdated
@anmonteiro anmonteiro force-pushed the anmonteiro/ignore-unset-sigchld-signals branch from 8da3fcc to 4a8c56a Compare April 5, 2026 17:36
@anmonteiro anmonteiro force-pushed the anmonteiro/ignore-unset-sigchld-signals branch from 4a8c56a to 149835e Compare April 5, 2026 17:56
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
@anmonteiro anmonteiro force-pushed the anmonteiro/ignore-unset-sigchld-signals branch from 149835e to 2c093c9 Compare April 5, 2026 21:17
@anmonteiro anmonteiro merged commit 828d180 into ocaml:main Apr 5, 2026
30 checks passed
@anmonteiro anmonteiro deleted the anmonteiro/ignore-unset-sigchld-signals branch April 5, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants