Fix multi-target revdep workflow invocation#14024
Merged
Leonidas-from-XIV merged 1 commit intoocaml:mainfrom Apr 6, 2026
Merged
Fix multi-target revdep workflow invocation#14024Leonidas-from-XIV merged 1 commit intoocaml:mainfrom
Leonidas-from-XIV merged 1 commit intoocaml:mainfrom
Conversation
Running it the revdep check using the bash syntax that is documented
does not work as the `{base,core}` is not expanded for some reason.
The failure looks like this:
```
Run packages="{base,core}"
warning: not writing modified lock file of flake 'git+file:///home/runner/work/dune/dune?shallow=1':
• Updated input 'revdeps-dune':
'github:ocaml/dune/898e0121ff1fb1b5499f9aa976ea5bfc4258cb29?narHash=sha256-1mstTMWySXgw6qwrB6Mhx3BiPSBI1wBfIvxNewnsGdA%3D' (2026-03-27)
→ 'path:/home/runner/work/dune/dune?lastModified=1775206722&narHash=sha256-DfDrJYjCed47uZ1SgXp0QVStg7ZSDkFFWz0P8We8NQY%3D' (2026-04-03)
copying path '/nix/store/0zjk4bg7bw2zsh3w0rnyn4b4hfiw0s9n-source' from 'https://cache.nixos.org'...
unpacking 'github:nix-ocaml/nix-overlays/3416a42c17fa31f6de8e40277f3b1c6e0b6f2fef?narHash=sha256-2bbvykJd8IwkmRPSfPRYLHpbAzLJTZY6SEWp%2B9me214%3D' into the Git cache...
unpacking 'github:melange-re/melange/0c7fbb6b6734d54e60b7e73d2d696ec31e90a0c8?narHash=sha256-/RWEvZeNeag3EKRFS9jIyaDLzl0kpmKEKq0htvDMg9g%3D' into the Git cache...
error: flake 'git+file:///home/runner/work/dune/dune?shallow=1' does not provide attribute 'packages.x86_64-linux.revdeps.x86_64-linux.{base,core}', 'legacyPackages.x86_64-linux.revdeps.x86_64-linux.{base,core}' or 'revdeps.x86_64-linux.{base,core}'
```
This PR changes the list of packages to be a space separated list
(fairly common in shell and opam package names do not contain spaces)
which gets explicitely expanded to the list of targets for `nix build`.
Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
changed the title
shonfeder
approved these changes
Apr 4, 2026
Member
shonfeder
left a comment
shonfeder
left a comment
There was a problem hiding this comment.
LGTM, assuming it has been tested!
Collaborator
Author
|
Yes, you can see the test run where I test both "base core" (two packages, this time space separated) linked above. Essentially I implement what the semantics of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running it the revdep check using the bash syntax that is documented does not work as the
{base,core}is not expanded for some reason.The failure looks like this:
This PR changes the list of packages to be a space separated list (fairly common in shell and opam package names do not contain spaces) which gets explicitly expanded to the list of targets for
nix build.A run with "base core" set as packages succeeds just fine: https://github.com/Leonidas-from-XIV/dune/actions/runs/23940067487/job/69824268157