Skip to content

test(win): unicode sandbox cleanup#13992

Draft
Alizter wants to merge 1 commit intoocaml:mainfrom
Alizter:push-zkwwsrnxvvqk
Draft

test(win): unicode sandbox cleanup#13992
Alizter wants to merge 1 commit intoocaml:mainfrom
Alizter:push-zkwwsrnxvvqk

Conversation

@Alizter
Copy link
Copy Markdown
Collaborator

@Alizter Alizter commented Mar 31, 2026

This test demonstrates that unicode file names can prevent a sandbox from being cleared properly.

This will be fixed together with the related issue of reparse points / junctions.

Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter Alizter force-pushed the push-zkwwsrnxvvqk branch from ca010e8 to daf8df3 Compare March 31, 2026 11:56
@Alizter Alizter requested a review from nojb March 31, 2026 11:57
@Alizter Alizter added the windows Issues that relate to Dune on Microsoft Windows label Mar 31, 2026
@Alizter
Copy link
Copy Markdown
Collaborator Author

Alizter commented Mar 31, 2026

The tests in the ci run under opam exec which appears to be fixing the issue, although I'm not quite sure how. I'll undraft when I understand what is happening a bit better.

@Alizter Alizter marked this pull request as draft March 31, 2026 13:01
@nojb
Copy link
Copy Markdown
Collaborator

nojb commented Mar 31, 2026

The tests in the ci run under opam exec which appears to be fixing the issue, although I'm not quite sure how. I'll undraft when I understand what is happening a bit better.

Unicode support in the Windows runtime is controlled by a ./configure-time variable WINDOWS_UNICODE_MODE (possible values: ansi, compatible). Maybe the test fails when using a runtime in ansi mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

windows Issues that relate to Dune on Microsoft Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants