Skip to content

rpc: clarify error when another dune instance is running#13983

Merged
rgrinberg merged 2 commits intoocaml:mainfrom
meet0806:fix/rpc-running-instance-error
Apr 5, 2026
Merged

rpc: clarify error when another dune instance is running#13983
rgrinberg merged 2 commits intoocaml:mainfrom
meet0806:fix/rpc-running-instance-error

Conversation

@meet0806
Copy link
Copy Markdown
Contributor

@meet0806 meet0806 commented Mar 30, 2026

Summary

  • improve forwarded-command error when another dune instance holds the global lock but RPC endpoint is unavailable
  • emit a clearer user-facing message: "Another Dune instance is currently running. Aborting..."
  • keep behavior deterministic (no pid in message) for stable cram expectations
  • update cram test expectation in custom-build-dir case

Validation

  • opam exec -- ./dune.exe runtest test/blackbox-tests/test-cases/cram/custom-build-dir.t

Fixes #13902

Signed-off-by: Meet Zalavadiya <zalavadiyameet0806@gmail.com>
@shonfeder shonfeder requested a review from ElectreAAS April 3, 2026 02:14
_
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
@rgrinberg rgrinberg merged commit eec706f into ocaml:main Apr 5, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve 'RPC server not running' error message

2 participants