feature: introduce DUNE_PROJECT_ROOT#13934
Merged
rgrinberg merged 1 commit intoocaml:mainfrom Apr 5, 2026
Merged
Conversation
rgrinberg
force-pushed
the
push-kpkylzrlwrnx
branch
from
cb0b6bc to
2d03e24
Compare
Collaborator
Member
Author
|
Providing this via the CLI is fine as well of course. |
Collaborator
Do these at least get included in the action digest? Surely changing the value of |
Member
Author
|
I don't know why you're so certain. We don't count INSIDE_DUNE towards the digest. |
rgrinberg
force-pushed
the
push-kpkylzrlwrnx
branch
from
2d03e24 to
419b05c
Compare
Quite often, actions want to run or look up something relative to their
project root rather than the directory when they're defined. The
standard workaround is to %{project_root} to these actions. However,
this workaround comes with some downsides:
1. One has to pass this variable manually, and this is rather
inconvenient for some actions (like preprocessors)
2. Passing the %{project_root} this way records the directory in the
action's digest. We shouldn't be encouraging actions from observing
the project root in this way.
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-kpkylzrlwrnx
branch
from
419b05c to
b1d37f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quite often, actions want to run or look up something relative to their project root rather than the directory when they're defined. The standard workaround is to %{project_root} to these actions. However, this workaround comes with some downsides:
One has to pass this variable manually, and this is rather inconvenient for some actions (like preprocessors)
Passing the %{project_root} this way records the directory in the action's digest. We shouldn't be encouraging actions from observing the project root in this way.