Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds byte-stream support to Lua file loading so loadfile/LoadFileAsync can distinguish binary vs text chunks, and expands the test suite around BOM handling, load modes, I/O buffering, and read sequencing.
Changes:
- Introduces
ILuaByteStreamand makesLuaStreamimplement it, enabling byte-based reads. - Updates
LuaStateExtensions.LoadFileAsyncandLuaState.Load(ReadOnlySpan<byte>)to enforcemode(b/t) and support binary chunk loading. - Adds new NUnit tests for BOM stripping, mode rejection behavior,
_ENVhandling,io.readsequencing, and line buffering.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Lua.Tests/LuaTests.cs | Adjusts files.lua patching to account for BOM handling and skips unsupported binary/string.dump coverage. |
| tests/Lua.Tests/LoadFileModeTests.cs | Adds tests asserting LoadFileAsync rejects chunks when mode disallows their type. |
| tests/Lua.Tests/LoadFileBomTests.cs | Adds tests ensuring UTF-8 BOM at start of file is ignored by loadfile. |
| tests/Lua.Tests/LoadEnvironmentTests.cs | Adds tests for explicit nil environments via load/loadfile. |
| tests/Lua.Tests/IoReadSequenceTests.cs | Adds regression test for io.read returning earlier results even when a later fixed read hits EOF. |
| tests/Lua.Tests/IoBufferingTests.cs | Adds test for line-buffered writes only becoming visible after newline. |
| src/Lua/LuaStateExtensions.cs | Updates LoadFileAsync to optionally use byte-stream reads and enforce mode rules. |
| src/Lua/LuaState.cs | Enforces mode rules in Load(ReadOnlySpan<byte>) for binary/text chunks. |
| src/Lua/IO/LuaStream.cs | Implements ILuaByteStream and updates buffering logic for setvbuf("line") / "no". |
| src/Lua/IO/ILuaByteStream.cs | Adds the new byte-stream interface. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
files.luapass.But need new
ILuaByteStreaminteface.