fix: harden wallet IPC, browser, and email flows#150
Open
nullxnothing wants to merge 2 commits intomainfrom
Open
fix: harden wallet IPC, browser, and email flows#150nullxnothing wants to merge 2 commits intomainfrom
nullxnothing wants to merge 2 commits intomainfrom
Conversation
Owner
Author
|
Conflict scope: 7 files including |
Owner
Author
|
Cleanup pass — needs author rebase: 7-file conflict, security-critical content. Auto-resolution risks weakening hardening intent. Specifically:
Plus 1 of 2 commits is already in main ( Recommend: extract just the hardening primitives (CIDR check, validators, tests) into a fresh PR against current main rather than rebasing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopened during repo cleanup pass. Branch was 4 weeks stale with no open PR but contains real unmerged work:
test/services/BrowserService.test.ts | 44 ++++++++++++++++
test/services/ValidationService.test.ts | 28 +++++++++++
11 files changed, 354 insertions(+), 31 deletions(-)
CI will indicate whether this still applies cleanly against current main (post v3.1 reworks).