Skip to content

crypto: add JWK support for ML-KEM and SLH-DSA key types#62706

Open
panva wants to merge 1 commit intonodejs:mainfrom
panva:pqc-jwk
Open

crypto: add JWK support for ML-KEM and SLH-DSA key types#62706
panva wants to merge 1 commit intonodejs:mainfrom
panva:pqc-jwk

Conversation

@panva
Copy link
Copy Markdown
Member

@panva panva commented Apr 12, 2026

  • ML-KEM JWK in node:crypto and Web Cryptography
  • SLH-DSA JWK in node:crypto

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 12, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva marked this pull request as ready for review April 12, 2026 12:49
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 12, 2026

Codecov Report

❌ Patch coverage is 86.08696% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.80%. Comparing base (dfe438d) to head (0e43511).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/crypto/crypto_pqc.cc 82.79% 3 Missing and 13 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62706      +/-   ##
==========================================
- Coverage   89.81%   89.80%   -0.01%     
==========================================
  Files         699      699              
  Lines      216379   216400      +21     
  Branches    41366    41385      +19     
==========================================
+ Hits       194340   194342       +2     
+ Misses      14139    14138       -1     
- Partials     7900     7920      +20     
Files with missing lines Coverage Δ
lib/internal/crypto/ml_kem.js 92.83% <100.00%> (+0.37%) ⬆️
lib/internal/crypto/webcrypto.js 96.58% <100.00%> (+0.01%) ⬆️
src/crypto/crypto_keys.cc 73.59% <100.00%> (-0.29%) ⬇️
src/crypto/crypto_pqc.cc 82.79% <82.79%> (ø)

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added crypto Issues and PRs related to the crypto subsystem. webcrypto labels Apr 12, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@panva panva requested review from anonrig and jasnell April 12, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crypto Issues and PRs related to the crypto subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. webcrypto

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants