diagnostics_channel: specialized tracing channels#62641
Draft
Qard wants to merge 1 commit intonodejs:mainfrom
Draft
diagnostics_channel: specialized tracing channels#62641Qard wants to merge 1 commit intonodejs:mainfrom
Qard wants to merge 1 commit intonodejs:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62641 +/- ##
==========================================
+ Coverage 89.72% 89.80% +0.08%
==========================================
Files 695 697 +2
Lines 214464 216293 +1829
Branches 41067 41405 +338
==========================================
+ Hits 192420 194251 +1831
- Misses 14106 14135 +29
+ Partials 7938 7907 -31
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still a work-in-progress, but I want to share this before the collab summit so people can see the direction I'm trying to go with this and think about it for the upcoming session on these and other Observability changes I'm working on.
The general idea is that TracingChannel having sync, callback, and promise trace functions was a bit inflexible. What I'm going for here is to split apart concerns into three tracing categories: calls, parameter mapping for callbacks, and return value mapping for promises and iterators.
I'll continue working on this, and especially improving the docs to explain these concepts in more detail.
cc @nodejs/diagnostics