test_runner: fix coverage ignore comments to exclude BRDA entries#62443
Open
wdskuki wants to merge 1 commit intonodejs:mainfrom
Open
test_runner: fix coverage ignore comments to exclude BRDA entries#62443wdskuki wants to merge 1 commit intonodejs:mainfrom
wdskuki wants to merge 1 commit intonodejs:mainfrom
Conversation
When using /* node:coverage ignore next */ comments, the test_runner correctly excluded DA (line coverage) entries from lcov output, but still included BRDA (branch coverage) entries as uncovered. This caused branch coverage to report lower percentages than expected. This fix ensures that branches completely covered by ignore comments are excluded from the branch coverage report, matching the behavior of c8 and user expectations. Fixes: nodejs#61586
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
JakobJingleheimer
added
the
duplicate
Member
|
Duplicate of #61598 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
/* node:coverage ignore next */comments, the test_runner correctly excluded DA (line coverage) entries from lcov output, but still included BRDA (branch coverage) entries as uncovered. This caused branch coverage to report lower percentages than expected.This fix ensures that branches completely covered by ignore comments are excluded from the branch coverage report, matching the behavior of c8 and user expectations.
Fixes: #61586