lib,src,test,doc: add node:ffi module by cjihrig · Pull Request #62072 · nodejs/node

cjihrig · 2026-03-02T14:43:52Z

This is not ready for review yet. Just opening to see if this is something the project is still interested in.

nodejs-github-bot · 2026-03-02T14:43:58Z

Review requested:

@nodejs/gyp
@nodejs/security-wg

anonrig · 2026-03-02T16:00:18Z

Yes

Qard

Looks very cool! I'm glad to see someone has picked this back up. 🙂

I did a quick review and it all looks good. My only comment is there seems to be a bunch of static strings and a private symbol which we might want to define in env_properties.h.

src/node_ffi.cc

github-actions · 2026-03-18T23:43:23Z

Failed to start CI

   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/23272564448

nodejs-github-bot · 2026-03-18T23:44:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71877/

nodejs-github-bot · 2026-03-18T23:54:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71878/

cjihrig · 2026-03-18T23:59:59Z

@anonrig I cancelled that CI run to save resources. I started https://ci.nodejs.org/job/node-test-pull-request/71877/ manually, and it's currently running.

@cjihrig

given that this is still draft and @cjihrig indicated it's not ready for review, a sign off is not yet appropriate.

mcollina

lgtm

nodejs-github-bot · 2026-03-19T03:10:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71884/

@cjihrig

given that this is still draft and @cjihrig indicated it's not ready for review, a sign off is not yet appropriate.

jasnell · 2026-03-19T03:41:32Z

@cjihrig ... definitely interested in seeing ffi land. I was hoping @bengl's prior efforts would make progress. Once you feel this is ready to go, I'll be happy to review.

mcollina

lgtm

mcollina · 2026-04-01T17:27:16Z

@cjihrig @ShogunPanda this now conflicts, can you rebase?

codecov · 2026-04-02T16:06:16Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.69%. Comparing base (726b220) to head (1432c97).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62072      +/-   ##
==========================================
- Coverage   89.81%   89.69%   -0.12%     
==========================================
  Files         699      706       +7     
  Lines      216331   218043    +1712     
  Branches    41355    41728     +373     
==========================================
+ Hits       194294   195577    +1283     
- Misses      14156    14379     +223     
- Partials     7881     8087     +206

Files with missing lines	Coverage Δ
lib/ffi.js	`95.85% <ø> (ø)`
lib/internal/bootstrap/realm.js	`96.21% <ø> (+<0.01%)`	⬆️
lib/internal/process/permission.js	`100.00% <ø> (ø)`
lib/internal/process/pre_execution.js	`98.63% <ø> (+1.40%)`	⬆️
src/env.cc	`85.45% <ø> (+0.34%)`	⬆️
src/ffi/data.cc	`78.77% <ø> (ø)`
src/ffi/types.cc	`59.67% <ø> (ø)`
src/node_binding.cc	`82.74% <ø> (ø)`
src/node_builtins.cc	`76.09% <ø> (-0.15%)`	⬇️
src/node_ffi.cc	`69.07% <ø> (ø)`
... and 8 more

... and 50 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

* src,deps,test: various improvements Signed-off-by: Paolo Insogna <paolo@cowtech.it> * deps,test: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * deps,test: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * deps,test: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * deps,test: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * doc,lib: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * deps: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * test: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> --------- Signed-off-by: Paolo Insogna <paolo@cowtech.it>

* test: fixed build on Windows Signed-off-by: Paolo Insogna <paolo@cowtech.it> * test: fixed build on Windows Signed-off-by: Paolo Insogna <paolo@cowtech.it> * test: fixed build on Windows Signed-off-by: Paolo Insogna <paolo@cowtech.it> * test: fixed build on Windows Signed-off-by: Paolo Insogna <paolo@cowtech.it> * test: removed useless file Signed-off-by: Paolo Insogna <paolo@cowtech.it> --------- Signed-off-by: Paolo Insogna <paolo@cowtech.it>

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

nodejs-github-bot · 2026-04-11T09:31:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72626/

nodejs-github-bot · 2026-04-11T13:42:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72634/

nodejs-github-bot · 2026-04-12T06:44:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72644/

nodejs-github-bot · 2026-04-12T07:28:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72645/

nodejs-github-bot · 2026-04-12T09:18:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72646/

nodejs-github-bot · 2026-04-12T10:30:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72650/

nodejs-github-bot · 2026-04-12T12:28:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72652/

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

nodejs-github-bot · 2026-04-12T13:35:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72654/

nodejs-github-bot added build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Mar 2, 2026

Qard reviewed Mar 2, 2026

View reviewed changes

src/node_ffi.cc Outdated Show resolved Hide resolved

cjihrig force-pushed the ffi branch 2 times, most recently from 9462e4d to 631d73a Compare March 10, 2026 03:46

cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2026

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 18, 2026

anonrig previously approved these changes Mar 18, 2026

View reviewed changes

anonrig added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Mar 18, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2026

mcollina previously approved these changes Mar 19, 2026

View reviewed changes

mcollina added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 19, 2026

cjihrig marked this pull request as ready for review April 1, 2026 14:41

mcollina approved these changes Apr 1, 2026

View reviewed changes

cjihrig and others added 19 commits April 11, 2026 11:15

lib,src,test,doc: add node:ffi module

e062695

ffi: Refactor to simpler API.

1f02596

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

fix: Various improvements.

55a94df

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

fix the build

c843df0

fix lint

277b2f5

remove test fixture readme

dffc12e

remove extra test file

674c956

tests

c4e89d0

src: formatted files

c64fa18

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

fixup

5f763e8

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

fixup

06c1d1a

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

test: fixed failures

608a073

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

src: formatted files

f00f504

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

src: fix arguments handling

d3e9d31

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

test: formatted files

2ac4a42

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

test: fix test library

d16506e

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

deps: fix build on Windows

bb30b89

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

ShogunPanda force-pushed the ffi branch from 5d70a57 to 4d36946 Compare April 11, 2026 09:16

src: add suffix and types

1432c97

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

ShogunPanda force-pushed the ffi branch from 9173247 to 1432c97 Compare April 12, 2026 13:34

Uh oh!

Conversation

cjihrig commented Mar 2, 2026

Uh oh!

nodejs-github-bot commented Mar 2, 2026

Uh oh!

anonrig commented Mar 2, 2026

Uh oh!

Qard left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 18, 2026

Uh oh!

nodejs-github-bot commented Mar 18, 2026

Uh oh!

nodejs-github-bot commented Mar 18, 2026

Uh oh!

cjihrig commented Mar 18, 2026

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Mar 19, 2026

Uh oh!

jasnell commented Mar 19, 2026

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

mcollina commented Apr 1, 2026

Uh oh!

codecov bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Apr 11, 2026

Uh oh!

nodejs-github-bot commented Apr 11, 2026

Uh oh!

nodejs-github-bot commented Apr 12, 2026

Uh oh!

nodejs-github-bot commented Apr 12, 2026

Uh oh!

nodejs-github-bot commented Apr 12, 2026

Uh oh!

nodejs-github-bot commented Apr 12, 2026

Uh oh!

nodejs-github-bot commented Apr 12, 2026

Uh oh!

nodejs-github-bot commented Apr 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

codecov bot commented Apr 2, 2026 •

edited

Loading