Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #723 +/- ##
=======================================
Coverage 76.15% 76.15%
=======================================
Files 151 151
Lines 13641 13641
Branches 1066 1066
=======================================
Hits 10388 10388
Misses 3248 3248
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a formal Markdown specification for the documentation format parsed by @node-core/doc-kit, intended to codify the supported structure and metadata conventions (and to address #402’s request to define a ruleset).
Changes:
- Introduces
docs/specification.mddescribing document structure, heading semantics, YAML-in-HTML-comment metadata, stability indicators, typed parameter lists, and cross-references. - Defines (in spec) a
<!--module=...-->directive for scoping sub-sections to a module.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| #### Static method: `Buffer.from(string[, encoding])` | ||
| ``` | ||
|
|
||
| #### 4.3.6. Property |
There was a problem hiding this comment.
Maybe good to clarify must be an exact match and that
### `buf.length` I like chocolateWouldn't match as Property type, same for Constructor, Method, etc
There was a problem hiding this comment.
"the heading text is a backtick-wrapped" means that the entire heading must be wrapped in backticks, but if that's not clear, does adding "Text MUST NOT exist outsides of the backtick-wrapped property access." help?
| Implementations MAY define reserved tag values for special purposes such as | ||
| content slot markers. | ||
|
|
||
| ### 6.6. Frontmatter Conversion |
There was a problem hiding this comment.
Probably noteworthy that non-builtin pieces such as "authors: idk" or something: value, are also stored but by default have no specific use but can be consumed by generators/plugins.
There was a problem hiding this comment.
Implementations MAY define reserved tag values for special purposes such as
content slot markers.
Is already mentioned
ovflowd
left a comment
ovflowd
left a comment
There was a problem hiding this comment.
SGTM! Really good stuff, this is phenomenal work. I've left a few comments!
avivkeller
force-pushed
the
specification
branch
from
6b39ab9 to
da789c7
Compare
|
| File | Base | Head | Diff |
|---|---|---|---|
orama-db.json |
8.08 MB | 8.08 MB | +1.00 B (+0.00%) |
Closes #402
This PR introduces a formal specification for the Markdown format consumed by doc-kit. I drafted it over the past few days while thinking through how to align webpack's documentation output (for our GSoC) with doc-kit's parseable structure, then revised and formalized it with AI.
The specification documents the Markdown we currently support. However, it defines a
<!--module=node:fs/promises-->directive, as @Ethan-Arrowood proposed in #402. This allows sub-sections of a document to be associated with a specific module when needed (see §4.4.4 and §6.2.6).