fix: add same-user multi-tab sync leadership#1119
Open
Conversation
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useLocalSyncLeaderanduseLocalSyncLeaderStoreto coordinate one browser-local execution leader per(fileId, userId)using a stabletabId,BroadcastChannelsignaling, and a shortlocalStoragelease/heartbeat. Election only activates for normal board sessions when bothfileIdand the JWT user id are available.App.tsxand the mutation-capable hooks/components now treat follower tabs as local viewers instead of editors.useSyncso authoritative outbound work only runs whenisDedicatedSyncer && isLocalLeader: scheduled sync execution, Nextcloud persistence, websocket scene/image sync, cursor and viewport emission, and unload or visibility flushes. When leadership is yielded, throttled work is cancelled before the final flush.useCollaborationso only the local leader answers targeted scene bootstrap and image requests. Follower tabs still stay connected for room state, broadcasts, and remote updates, but they do not emit duplicate same-user sync or responder traffic.