fix(mention): custom range for usernames and error handling#12657
Open
fix(mention): custom range for usernames and error handling#12657
Conversation
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
| contactResults = await autoCompleteByName(text) | ||
| contactResults = contactResults.filter((result) => result.email?.filter((email) => email.length > 0)) | ||
| } catch (error) { | ||
| console.error(error) |
Member
There was a problem hiding this comment.
use the logger with a meaningful log message. log the error as context
| } | ||
| if (eventData.marker === '@') { | ||
| this.editorInstance.execute('insertItem', { email: item.email[0], label: item.label }, '@') | ||
| const lookback = this.contactMentionQuery?.length + 1 || 5 // +1 for the '@' itself |
Member
There was a problem hiding this comment.
Works, but adding +1 to a possible undefined and then falling back to another value is hard to read
> const obj = {}
undefined
> obj?.foo + 1 || 5
5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Bugs:
@and your query is longer than 5 characters the user is added totobut the text is never replacednullemails you get no suggestions and it fails silentlyShould be probably generalized for all triggers mainly Text blocks and links