Skip to content

Create notification upon IMip message processing failure#12552

Open
Juniar-Rakhman wants to merge 4 commits intonextcloud:mainfrom
Juniar-Rakhman:main
Open

Create notification upon IMip message processing failure#12552
Juniar-Rakhman wants to merge 4 commits intonextcloud:mainfrom
Juniar-Rakhman:main

Conversation

@Juniar-Rakhman
Copy link
Copy Markdown

@Juniar-Rakhman Juniar-Rakhman commented Mar 12, 2026

This is a follow up PR based on feedback on the original PR, which in turn is a follow up changes to a patch done for #10811

The patch to address above issue fixes the processing flow of iMip message processing. When a failure occurs, the batch job logs the error and continues processing the next iMIP message instead of failing the entire job.

Issue:
Although the patch resolves the processing problem, failures occur silently from the user’s perspective. The user is not informed when an iMIP message fails to process and therefore cannot take corrective action.

Solution:
Created a notification upon iMIP messaging failure that will be sent to message owner so they can take corrective actions.

Added the following changes:

  1. Error recovery with notification instead of failing silently.
  2. Added sendErrorNotification() method to generate Nextcloud notification
  3. Added a new notification subject 'imip_processing_failed' handled by the Mail app notifier.
  4. When an error occurs, the user receives a Nextcloud notification explaining that the invitation could not be processed automatically.
  5. The notification includes a direct link to the affected email, allowing the user to open it and manually add the calendar event.

@welcome
Copy link
Copy Markdown

welcome bot commented Mar 12, 2026

Thanks for opening your first pull request in this repository! ✌️

@Juniar-Rakhman Juniar-Rakhman marked this pull request as ready for review March 12, 2026 10:48
@Juniar-Rakhman
Copy link
Copy Markdown
Author

Juniar-Rakhman commented Mar 12, 2026

Tested in one of our nextcloud instance and the notification is working well as shown below.

When IMip processing failure occured, a notification is shown to the user.

2026-03-12_17-42

When clicked, user will be redirected to the failed email message. They can then take corrective action by manually adding the attached invitation to their calendar.

2026-03-12_17-43

For Users that do not use Nextcloud web, they might missed the notification, but they should receive the email about unread notifications after 1 hour (configurable).

image

@ChristophWurst ChristophWurst marked this pull request as draft March 12, 2026 10:52
@ChristophWurst ChristophWurst changed the title [WIP] - Create notification upon IMip message processing failure Create notification upon IMip message processing failure Mar 12, 2026
@Juniar-Rakhman Juniar-Rakhman marked this pull request as ready for review March 12, 2026 11:12
@Juniar-Rakhman
Copy link
Copy Markdown
Author

Juniar-Rakhman commented Mar 16, 2026

The changes in this PR are not ideal for us since iMIP messages are time-sensitive and most of our users do not use the Nextcloud web interface.

In our production instance, we address this by implementing both push and email notifications. The email notification sent to the user is similar to the one in the original PR. The custom code changes that have been working for us can be found here.

Ideally, I would prefer to configure this notification similar to the "Activity" notifications:

image

For example, by adding a setting called "iMIP Processing Failure" under "Other activities".

However, this would likely require more extensive changes to the Notifications app as well.

For now, I think the changes in this PR are sufficient to address the main issue.

@SebastianKrupinski
Copy link
Copy Markdown
Contributor

Hi @Juniar-Rakhman

Thank you for the PR, please give us some time to review it

Refator unit test for IMipService.php
@Juniar-Rakhman Juniar-Rakhman requested a review from GretaD as a code owner March 18, 2026 08:45
@Juniar-Rakhman
Copy link
Copy Markdown
Author

Hi @SebastianKrupinski

Thank you for taking the time to review it. Looking forward to your feedback.

@github-actions
Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants