fix: use Kubernetes binaryData field for binary config values#392
Open
thokra-nav wants to merge 1 commit intomainfrom
Open
fix: use Kubernetes binaryData field for binary config values#392thokra-nav wants to merge 1 commit intomainfrom
thokra-nav wants to merge 1 commit intomainfrom
Conversation
The old approach stored binary values as base64 strings in the ConfigMap data field and tracked them via a nais.io/binary-keys annotation. A heuristic fallback for configs without the annotation tried to detect binary values by base64-decoding and checking utf8.Valid, but this incorrectly flagged common short strings like "true", "test", "json", "info", "8080", etc. as binary. Replace this with the native Kubernetes separation: plain text values go in data, binary values go in binaryData. This eliminates the annotation and the broken heuristic entirely. Add/update/remove operations now move values between the two fields based on encoding, and reads simply map data to PLAIN_TEXT and binaryData to BASE64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old approach stored binary values as base64 strings in the ConfigMap data field and tracked them via a nais.io/binary-keys annotation. A heuristic fallback for configs without the annotation tried to detect binary values by base64-decoding and checking utf8.Valid, but this incorrectly flagged common short strings like "true", "test", "json", "info", "8080", etc. as binary.
Replace this with the native Kubernetes separation: plain text values go in data, binary values go in binaryData. This eliminates the annotation and the broken heuristic entirely. Add/update/remove operations now move values between the two fields based on encoding, and reads simply map data to PLAIN_TEXT and binaryData to BASE64.