[code-infra] Add HTML validation to broken links checker by Janpot · Pull Request #1241 · mui/mui-public

Janpot · 2026-03-24T12:35:06Z

Summary

Adds optional HTML validation to the broken links checker via a new htmlValidate option (true, false, or a custom config object)
Ships a mui:recommended preset that extends html-validate:standard, html-validate:document, and html-validate:browser
Moves the entire per-URL crawl pipeline (fetch, parse, link/target extraction, HTML validation) into a dedicated crawlWorker.mjs worker thread — one worker per URL
Main thread now only handles queue management, deduplication, and post-crawl analysis
Adds typed CrawlWorkerInput/CrawlWorkerOutput contracts between parent and worker
Unifies all issues (broken links, broken targets, HTML validation) into a single issues array on CrawlResult using a discriminated union (BrokenLinkIssue | HtmlValidateIssue), removing the separate htmlValidateResults field

Update @mui/internal-code-infra to preview version from mui/mui-public#1241 and enable htmlValidate: true. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Add an `htmlValidate` option to the crawl config that validates HTML content of crawled pages using the html-validate library. The option accepts `true` (uses recommended rules), or a config object supporting `extends: ['mui:recommended']` for the default preset. Config is always static (never loaded from disk). Reports are printed per page. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Replace manual string replacement of mui:recommended in extends with html-validate's staticResolver API, which properly registers the preset so html-validate's own config resolution handles it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Move fetch, parse, link/target extraction, and HTML validation into a single crawlWorker per URL. The main thread now only handles queue management, deduplication, and post-crawl analysis. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Merge broken link and HTML validation issues into a single `issues` array on CrawlResult, using a discriminated union (`BrokenLinkIssue | HtmlValidateIssue`). This removes the separate `htmlValidateResults` field and simplifies consumers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Update @mui/internal-code-infra to preview version from mui/mui-public#1241 and enable htmlValidate: true. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

code-infra-dashboard · 2026-04-15T12:33:08Z

Deploy preview

https://deploy-preview-1241--mui-internal.netlify.app/

Bundle size

Bundle	Parsed size	Gzip size
@base-ui/react	0B^(0.00%)	0B^(0.00%)
@mui/x-charts-pro	0B^(0.00%)	0B^(0.00%)

Details of bundle changes

Performance

Total duration: 24.40 ms 🔺+8.27 ms^(+51.2%) | Renders: 4 ⁽⁺⁰⁾ | Paint: 109.92 ms 🔺+40.94 ms^(+59.3%)

Test	Duration	Renders
DataGrid mount with paint timing	3.31 ms 🔺+1.40 ms^(+73.2%)	1 ⁽⁺⁰⁾
HeavyList mount	16.85 ms 🔺+6.91 ms^(+69.4%)	1 ⁽⁺⁰⁾
Counter click	4.24 ms ▼-0.04 ms^(-0.9%)	2 ⁽⁺⁰⁾

Details of benchmark changes

Check out the code infra dashboard for more information about this PR.

Update @mui/internal-code-infra to preview version from mui/mui-public#1241 and enable htmlValidate: true. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

oliviertassinari

Cool stuff, e.g. would catch mui/mui-x#12285 early.

I will be curious to see how https://html-validate.org/ performs compared. to https://validator.w3.org/.

Janpot · 2026-04-16T14:22:13Z

I will be curious to see how https://html-validate.org/ performs compared. to https://validator.w3.org/.

Yeah, it just integrates very easily, but it has sharp edges. The maintainer is very responsive though. We can always swap it out for something else or drop it altogether.

oliviertassinari deployed to add-html-validate-to-broken-links-checker - code-infra-dashboard PR #1241 March 24, 2026 12:35 — with Render View deployment

oliviertassinari deployed to add-html-validate-to-broken-links-checker - mui-tools-public PR #1241 March 24, 2026 12:35 — with Render View deployment

Janpot mentioned this pull request Mar 24, 2026

[docs-infra] Test HTML validation in broken links checker mui/material-ui#48088

Draft

Janpot force-pushed the add-html-validate-to-broken-links-checker branch from 4638e80 to 8d7f40e Compare March 25, 2026 10:30

oliviertassinari deployed to add-html-validate-to-broken-links-checker - mui-tools-public PR #1241 March 25, 2026 10:30 — with Render View deployment

Janpot changed the title ~~[code-infra] Add optional HTML validation to broken links checker~~ [code-infra] Add HTML validation to broken links checker Mar 25, 2026

oliviertassinari requested a deployment to add-html-validate-to-broken-links-checker - mui-tools-public PR #1241 March 27, 2026 14:53 — with Render In progress

oliviertassinari temporarily deployed to add-html-validate-to-broken-links-checker - code-infra-dashboard PR #1241 March 27, 2026 14:53 — with Render Destroyed

oliviertassinari deployed to add-html-validate-to-broken-links-checker - mui-tools-public PR #1241 March 27, 2026 14:53 — with Render View deployment

oliviertassinari requested a deployment to add-html-validate-to-broken-links-checker - code-infra-dashboard PR #1241 March 27, 2026 14:53 — with Render In progress

oliviertassinari had a problem deploying to add-html-validate-to-broken-links-checker - code-infra-dashboard PR #1241 March 27, 2026 14:53 — with Render Failure

oliviertassinari deployed to add-html-validate-to-broken-links-checker - mui-tools-public PR #1241 March 27, 2026 15:01 — with Render View deployment

oliviertassinari temporarily deployed to add-html-validate-to-broken-links-checker - code-infra-dashboard PR #1241 March 28, 2026 22:56 — with Render Destroyed

Janpot and others added 10 commits March 30, 2026 16:41

try worker

7dbe11d

Update index.mjs

6ed8874

Update crawlWorker.mjs

9912daa

Update index.mjs

bad8741

[code-infra] Exit with non-zero code on HTML validation issues

4e9061a

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Update pnpm-lock.yaml

78e5b67

Janpot force-pushed the add-html-validate-to-broken-links-checker branch from 5dab8b0 to 83f4fec Compare March 30, 2026 14:41

oliviertassinari deployed to add-html-validate-to-broken-links-checker - mui-tools-public PR #1241 March 30, 2026 14:41 — with Render View deployment

Update pnpm-lock.yaml

e53ab4c

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

oliviertassinari temporarily deployed to add-html-validate-to-broken-links-checker - mui-tools-public PR #1241 March 30, 2026 14:52 — with Render Destroyed

zannager added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Apr 6, 2026

Merge branch 'master' into add-html-validate-to-broken-links-checker

b55f137

oliviertassinari had a problem deploying to add-html-validate-to-broken-links-checker - mui-tools-public PR #1241 April 8, 2026 12:42 — with Render Failure

oliviertassinari temporarily deployed to add-html-validate-to-broken-links-checker - code-infra-dashboard PR #1241 April 8, 2026 12:42 — with Render Destroyed

Update pnpm-lock.yaml

2be066d

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

oliviertassinari temporarily deployed to add-html-validate-to-broken-links-checker - mui-tools-public PR #1241 April 8, 2026 14:13 — with Render Destroyed

Janpot marked this pull request as ready for review April 8, 2026 14:24

dav-is mentioned this pull request Apr 9, 2026

[docs] Fix HTML validation issues #1295

Draft

Janpot requested a review from a team April 13, 2026 11:21

Merge branch 'master' into add-html-validate-to-broken-links-checker

354f84f

oliviertassinari had a problem deploying to add-html-validate-to-broken-links-checker - mui-tools-public PR #1241 April 15, 2026 12:24 — with Render Failure

oliviertassinari temporarily deployed to add-html-validate-to-broken-links-checker - code-infra-dashboard PR #1241 April 15, 2026 12:24 — with Render Destroyed

Update pnpm-lock.yaml

c1d9194

oliviertassinari temporarily deployed to add-html-validate-to-broken-links-checker - mui-tools-public PR #1241 April 15, 2026 12:32 — with Render Destroyed

mui deleted a comment from mui-bot Apr 15, 2026

brijeshb42 approved these changes Apr 15, 2026

View reviewed changes

Janpot merged commit 78ca9de into master Apr 15, 2026
13 checks passed

Janpot deleted the add-html-validate-to-broken-links-checker branch April 15, 2026 13:15

oliviertassinari added the type: new feature Expand the scope of the product to solve a new problem. label Apr 16, 2026

oliviertassinari reviewed Apr 16, 2026

View reviewed changes

oliviertassinari mentioned this pull request Apr 19, 2026

[docs] Use React.useId() for demo IDs mui/material-ui#48300

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[code-infra] Add HTML validation to broken links checker#1241

[code-infra] Add HTML validation to broken links checker#1241
Janpot merged 15 commits intomasterfrom
add-html-validate-to-broken-links-checker

Janpot commented Mar 24, 2026 •

edited

Loading

Uh oh!

code-infra-dashboard Bot commented Apr 15, 2026 •

edited

Loading

Uh oh!

Uh oh!

oliviertassinari left a comment •

edited

Loading

Uh oh!

Janpot commented Apr 16, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Janpot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

code-infra-dashboard Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploy preview

Bundle size

Performance

Uh oh!

Uh oh!

oliviertassinari left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Janpot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Janpot commented Mar 24, 2026 •

edited

Loading

code-infra-dashboard Bot commented Apr 15, 2026 •

edited

Loading

oliviertassinari left a comment •

edited

Loading

Janpot commented Apr 16, 2026 •

edited

Loading