Skip to content

Add more tools (based on searchfox-py) to the LLM review agent, and make it patch stack aware to a certain extent #6051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
padenot wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add more tools (based on searchfox-py) to the LLM review agent, and make it patch stack aware to a certain extent #6051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7263f4a
Make expand_context patch-stack aware
padenot May 26, 2026
3917e53
Add searchfox-based tools to the code review agent
padenot May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion bugbug/tools/code_review/agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,17 @@
from bugbug.tools.code_review.database import ReviewCommentsDB
from bugbug.tools.code_review.langchain_tools import (
CodeReviewContext,
calls_between,
calls_from,
calls_to,
check_can_gc,
create_find_function_definition_tool,
expand_context,
find_definition,
get_blame,
get_field_layout,
search_identifier,
search_text,
)
from bugbug.tools.code_review.prompts import (
CODE_REVIEW_TODO_PROMPT,
Expand Down Expand Up @@ -94,7 +103,18 @@ def __init__(
self.patch_summarizer = patch_summarizer
self.suggestion_filterer = suggestion_filterer

tools = [expand_context]
tools = [
expand_context,
search_text,
get_blame,
get_field_layout,
find_definition,
search_identifier,
calls_from,
calls_to,
calls_between,
check_can_gc,
]
Comment on lines +106 to +117
Copy link
Copy Markdown
Collaborator

@marco-c marco-c May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be preferable to have this as a list somewhere and then use it here and import it above, so we don't have to remember when we add a new searchfox tool that we also need to add it here

if function_search:
tools.append(create_find_function_definition_tool(function_search))
Copy link
Copy Markdown
Collaborator

@marco-c marco-c May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this anymore, do we?


Expand Down
Loading