docs(shadow-prove): clarify version is read for logging only in calc_batch_pi#957
Conversation
…batch_pi `calc_batch_pi` extracts `version` from the batch header but never branches on it, which looks inconsistent with the V2/non-V2 split in `lib.rs` and could be mistaken for a missing dispatch. The public-input formula is in fact uniform across versions: offset 57 holds the blob input field (versioned hash for V0/V1, aggregated hash for V2) and the on-chain verifier uses the same layout, while version-dependent routing happens earlier via the `batch_version` request parameter. Add a comment so maintainers don't need to reverse-engineer this from the header layout.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
shadow_rollup::calc_batch_piextractsversionfrom the batch header but never branches on it, which looks inconsistent with the V2/non-V2 split inlib.rsand could be mistaken for a missing dispatch.batch_versionrequest parameter.Test plan
cargo check -p shadow-proving